Tools: Move exporter alias handling to CLI

[theotherjimmy]

Description

Both the online compiler and the offline tools use the same code for
exporting and compilation. This is great, as it significantly reduces
code duplication and maintenance efforts. A knock-on effect of this
is that the exporters available on the command line are all available
online. Including the aliases.

This PR removes the aliases from the online compiler.

@thegecko as promised.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

[thegecko]

Thanks @theotherjimmy

[cmonr]

Neat

[cmonr]

/morph build

[mbed-ci]

Build : ABORTED

Build number : 2539
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7410/

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2546
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7410/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : FAILURE

Build number : 2190
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7410/

[mbed-ci]

Test : SUCCESS

Build number : 2301
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7410/2301

[cmonr]

@theotherjimmy It looks like there were CI node issues:

02:59:48 Traceback (most recent call last):
02:59:48   File "/builds/ws/exporter-build-matrix/2190/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky/mbed-os/tools/project.py", line 311, in <module>
02:59:48     main()
02:59:48   File "/builds/ws/exporter-build-matrix/2190/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky/mbed-os/tools/project.py", line 270, in main
02:59:48     profile = extract_profile(parser, options, toolchain_name, fallback="debug")
02:59:48 UnboundLocalError: local variable 'toolchain_name' referenced before assignment

[theotherjimmy]

@cmonr That's a bug.

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2550
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7410/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : SUCCESS

Build number : 2307
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7410/2307

[mbed-ci]

Exporter Build : FAILURE

Build number : 2195
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7410/

[cmonr]

11:47:18 usage: examples.py export [-h] [-m MCU] [ide [ide ...]]
11:47:18 examples.py export: error: argument ide: uvision is not a supported ide. Supported ides are:
11:47:18 sw4stm32,        netbeans,        eclipse_iar,     make_iar, 
11:47:18 eclipse_armc5,   mcuxpresso,      make_armc6,      make_armc5, 
11:47:18 vscode_iar,      iar,             gnuarmeclipse,   ds5_5, 
11:47:18 cces,            vscode_gcc_arm,  embitz,          vscode_armc5, 
11:47:18 uvision5,        e2studio,        codeblocks,      make_gcc_arm, 
11:47:18 qtcreator,       eclipse_gcc_arm, cmake_gcc_arm    

@theotherjimmy You'll need to look at how the export job is configured to reproduce locally.

[theotherjimmy]

Thanks @cmonr I have enough info to take it from here.

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2554
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7410/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : FAILURE

Build number : 2199
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7410/

[theotherjimmy]

Looks like I have to do this the hard way: make the CI not use the aliases.

[cmonr]

@studavekar You'll help will be needed here.

[mbed-ci]

Test : SUCCESS

Build number : 2311
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7410/2311

[0xc0170]

Looks like I have to do this the hard way: make the CI not use the aliases.

Trying to understand it here. uvision is being removed completely from exporters ? That is what is failing in the CI. This is a breaking change, isn't it?

[theotherjimmy]

@0xc0170 No. uvision is still supported.

[theotherjimmy]

@0xc0170 What's failing CI is that the CI is attempting to inspect the uvision exporter's supported list, which can't be done on account of the fact that the actual exporter is uvision5. uvision is now treated like another name for the uvision5 exporter instead of an identical exporter.

[cmonr]

@studavekar Mind taking a look at this? This needs a tweak to the CI config.

[cmonr]

@0xc0170 Changing this back to Needs: CI since no PR work is needed and is still ready to run.

[studavekar]

@0xc0170 What's failing CI is that the CI is attempting to inspect the uvision exporter's supported list, which can't be done on account of the fact that the actual exporter is uvision5. uvision is now treated like another name for the uvision5 exporter instead of an identical exporter.

@cmonr @theotherjimmy

If I go ahead and make the changes in CI right now, Other PR would fail which are in the queue.
I can make the changes lets halt the pipeline till this PR gets merged, does that sound ok?

[theotherjimmy]

@studavekar Sure, if that's needed. We're changing from one valid exporter to another, so I did not think that would change much.

[cmonr]

The exporter queue was empty so it fine to do.

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2202
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7410/

[studavekar]

@cmonr can you merge this PR. other PR exporter build would fail if this change is not in..

[theotherjimmy]

@studavekar As I have said multiple times in this thread, that's not true. This does not change anything about what mbed export accepts to it's -i option.

[studavekar]

@studavekar As I have said multiple times in this thread, that's not true. This does not change anything about what mbed export accepts to it's -i option.

@theotherjimmyI felt that this would break exporter because the last exporter result #7410 (comment)

00:00:25.441   File "../mbed-os/tools/test/examples/examples.py", line 133, in <module>
00:00:25.441     sys.exit(main())
00:00:25.441   File "../mbed-os/tools/test/examples/examples.py", line 84, in main
00:00:25.441     return args.fn(args, config, examples)
00:00:25.441   File "../mbed-os/tools/test/examples/examples.py", line 90, in do_export
00:00:25.441     results = lib.export_repos(config, args.ide, args.mcu, examples)
00:00:25.441   File "C:\builds\ws\exporter-build-matrix\2199\ARCH_PRO_uvision\sources\mbed-os\tools\test\examples\examples_lib.py", line 279, in export_repos
00:00:25.441     example['features'], example['toolchains']):
00:00:25.441   File "C:\builds\ws\exporter-build-matrix\2199\ARCH_PRO_uvision\sources\mbed-os\tools\test\examples\examples_lib.py", line 120, in target_cross_ide
00:00:25.441     if (EXPORTERS[ide].is_target_supported(target) and
00:00:25.441 KeyError: u'uvision

We have updated the CI to use uvision5 as argument instead of uvision and its passing

[theotherjimmy]

@studavekar That's part of the changes in this PR. I did not add uvision5 in this PR, it's been here for 2 years.