Cellular: Remove max_packet_size

[AriParkkila]

Description

Removed get_max_packet_size() from the cellular AT stack. Now the implementation always tries to write a packet to modem without checking its size. If the size was bigger than protocol MTU or that modem can handle, then modem will return an error.

There is no change in API (except a slight delay due to extra AT command/response), because sendto() API request still returns the same error code as before.

Fixes PR #7181 and Arm internal ref IOTCELL-1089.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

[AriParkkila]

@mirelachirica @jarvte please review

[mirelachirica]

The bellow CHECK should be modified to check against NSAPI_ERROR_OK. Previously the socket_send was checking size against max_packet_size which in this case was default 0, and as a result was returning NSAPI_ERROR_DEVICE_ERROR.

void Test_AT_CellularStack::test_AT_CellularStack_socket_send() ... CHECK(NSAPI_ERROR_DEVICE_ERROR == st.socket_send(sock, "addr", 4)); }

[0xc0170]

@mirelachirica Is this request for changes?

[mirelachirica]

Yes, test_AT_CellularStack_socket_send needs to be updated.

[cmonr]

@AriParkkila Any update?

[mirelachirica]

@cmonr Ari is on holiday. I might look into this and do the fix.

[mirelachirica]

Rebased and fixed the socket_send unit test.

[cmonr]

LGTM

[cmonr]

/morph build

[cmonr]

@AriParkkila Would it be possible to get someone else from @ARMmbed/mbed-os-wan to approve the changes as well?

[mbed-ci]

Build : SUCCESS

Build number : 2572
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7318/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2216
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7318/

[mbed-ci]

Test : FAILURE

Build number : 2326
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7318/2326

[0xc0170]

@ARMmbed/team-st-mcd Can you review the test failures above? We have noticed this in the recent CI runs, started few hours ago. 2 nucleo boards.

[jeromecoutant]

Hi Martin

same comment as #7471 (comment)

/morph build

[0xc0170]

@jeromecoutant I see now. there is a dependency issue that we were not aware?

This however does not explain what I've just reproduced locally

// 2 commands run to execute the test
mbed test -m NUCLEO_F401RE -t ARM -n tests-mbed_hal-sleep -DMBED_MEM_TRACING_ENABLED=1 -DMBED_HEAP_STATS_ENABLED=1 --compile
mbedgt -n tests-mbed_hal-sleep -v -V

// results

[1531398737.41][CONN][RXD] ++ MbedOS Error Info ++
[1531398737.47][CONN][RXD] Error Status: 0x80FF0100 Code: 256 Module: 255
[1531398737.51][CONN][RXD] Error Message: Fatal Run-time error
[1531398737.53][CONN][RXD] Location: 0x8007A17
[1531398737.54][CONN][RXD] Error Value: 0x0
[1531398737.65][CONN][RXD] Current Thread: Id: 0x20002400 Entry: 0x800A0ED StackSize: 0x1000 StackMem: 0x20001400 SP: 0x20002328
[1531398737.67][CONN][RXD] -- MbedOS Error Info --
[1531398737.71][CONN][RXD] Cannot initialize RTC with LSE

Got F401RE, no changes to master (using e1df16e84 - (HEAD -> master, upstream/master) Merge pull request #7365 from jeromecoutant/PR_RTC_SHADOW (10 hours ago) - latest master

[0xc0170]

This indicates the problem for lp ticker in the rtc init . Please try to reproduce this locally and let us know. Not sure why the CI did not fail for any prior PR (I reviewed RTC shadow PR today again to make sure it was all green really)

[mbed-ci]

Build : SUCCESS

Build number : 2585
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7318/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[0xc0170]

@jeromecoutant Created tracking issue for this where we can continue #7497

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2227
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7318/

[cmonr]

@ARMmbed/mbed-os-wan Would you mind reviewing? This PR is almost ready to come in.

[mbed-ci]

Test : SUCCESS

Build number : 2336
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7318/2336

[mirelachirica]

@TeemuKultala can you review this?