[RZ/A1H] mbed-RZ first release #594

tkuro-rel · 2014-10-23T08:54:50Z

including

mbed cmsis for RZ/A1H
mbed hal for RZ/A1H
- GPIO, Timer, I2C, SPI, InterruptIn
CA9 related files
RTOS support files for RZ/A1H

including - mbed cmsis for RZ/A1H - mbed hal for RZ/A1H - GPIO, Timer, I2C, SPI, InterruptIn - CA9 related files - RTOS support files for RZ/A1H

bogdanm · 2014-10-23T10:56:35Z

Hello,

Thanks for your pull request. There is a single, very large commit in this pull request, which prevents github from displaying it completely, which, in turn, prevents us from adding the proper comments. Could you please split it into multiple, smaller commits? For example:

one commit for build system changes
one commit for RTOS changes
one commit for HAL changes
one commit for CMSIS changes

This is just a suggestion, your commits can be even smaller than this and can follow a different structure.

Thanks,
Bogdan

tkuro-rel · 2014-10-23T11:39:59Z

Hello,
Thank you for suggestions.
The original branch is split more finely. I feel suggested level seems nice. I will split and organize commit tomorrow.

Regards,
Kurosawa

This reverts commit b78ac75.

- add CA9 category to build.py - add library for RTX-CA9 - add target definition for RZ/A1H - change some test related settings for RZ/A1H - add gcc options for CA9

- adds CA9 related headers - adds start up routine (only ARMCC is supported) - adds scatter file for RZ/A1H - adds GIC driver - adds peripheral definitions(iodefine) for RZ/A1H - adds serial flash boot loader for RZ/A1H

- adds GPIO driver - adds I2C driver - adds SPI driver - adds PWM driver - adds serial driver (irq not supported) - adds ticker driver - add analogin driver

- adds RTX-CA related files - changes Thread.cpp for CA9 - adds GR-PEACH entry to README.md

There was two sections for sflash which lead to separate output .bin file. Fixed.

RZ/A1H has GIC instead of NVIC. InterruptManger assumes NVIC only, so temporarily ifdef guarded in order to pass the compilation.

tkuro-rel · 2014-10-24T04:15:24Z

I split commits to 4 levels and fixed some bugs, and added description for GR-PEACH in README.md.
Could you please check commits and merge them if there's no problem.

This reverts commit c713db8.

tkuro-rel · 2014-10-24T08:53:00Z

there're some changes after this pull-request.
Is it better to close this Pull-request once? Or continue anyway?

0xc0170 · 2014-10-24T08:56:50Z

You can push commits if you consider there should be part of this pull request.
Please share with us if there's still a development ongoing, otherwise it's considered to be feature completed and available for review/merge/test.

tkuro-rel · 2014-10-24T09:21:26Z

These USB related commits are the last.　it's considered to be feature completed and available for review/merge/test. thank you very much in advance.

bogdanm · 2014-10-24T15:45:25Z

This does not compile for me using GNU ARM embedded with gcc 4.7.4, I get loads of error in mmu_Renesas_RZ_A1.c. To reproduce:

workspace_tools\build.py -t GCC_ARM -m RZ_A1H

This reverts commit 6aaae4a.

…es the illegal memory access

GCC is not supported by now, so eliminate GCC_ARM in targets.py and fpu related settings in toolchains/gcc.py

tkuro-rel · 2014-10-29T08:58:33Z

Hello, bogdanm-san,

GCC is not currently supported. So I reverted gcc related .py files.
I'm sorry for confusion by my mistake.

Regard,
Kurosawa

Although the Ethernet functionality is not for review.

masaohamanaka-zz · 2014-10-31T08:10:45Z

Hello

I posted Ethernet related commits.
Although the Ethernet functionality is not for review.

Regard,
Hamanaka

0xc0170 · 2014-10-31T08:25:11Z

Hi,

thanks. Why did you decide to add Ethernet if there's a message: not for review ? If it's not feature complete, it should be on the separate branch and push to a master once "ready for review and functional".

Regards,
0xc0170

masaohamanaka-zz · 2014-10-31T08:41:02Z

Hi, 0xc0170-san

Function of Ethernet is complete.
There will be a event for early beta testers and we must include the Ethernet functionality.
So, I decided to include to this request.

Regards,
Hamanaka

bogdanm · 2014-11-03T15:05:52Z

The USB stack does not compile for me:

workspace_tools\build.py -t ARM -m RZ_A1H -u
Building library CMSIS (RZ_A1H, ARM)
Building library MBED (RZ_A1H, ARM)
Building library USBDEVICE (RZ_A1H, ARM)
Compile: USBAudio.cpp
[Error] iodefine.h@97: #5: cannot open source input file "iodefines/adc_iodefine.h": No such file or directory
"no source": Warning: #3036-D: "c:/software/armcc5.03.117\include" was specified as both a system and non-system include directory -- the non-system entry will be ignored
"c:/work/mbed/build\mbed\TARGET_RZ_A1H/iodefine.h", line 97: Error: #5: cannot open source input file "iodefines/adc_iodefine.h": No such file or directory
C:\work\mbed\github-new\libraries\USBDevice\USBAudio\USBAudio.cpp: 1 warning, 1 error

Completed in: (0.33)s

Build failures:

ARM::RZ_A1H

…on moved into USBHAL_RZA1H.cpp. * Interrupts registration routine returned to the original sample code.

RZ's toolchain assumes that iodefines/iobitmasks dirs. are structured real not flat. Adds some code to toolchain::copy_files

This reverts commit 2fab4af.

RZ's toolchain assumes that iodefines/iobitmasks dirs. are structured real not flat. Adds some code to toolchain::copy_files

- some topics - subsub toppics

This reverts commit dcca0bf.

…in USBHAL.h moved into USBHAL_RZ_A1H.cpp. * Some functions writing by c++ changed to macro function.

Fixed copyright and correction of erroneous description.

Conflicts: workspace_tools/targets.py

tkuro-rel · 2014-11-06T07:24:19Z

Hello, bogdanm-san

The USB stack does not compile for me:

Now USB lib can be (hopefully) compiled. Could you ,please try it again?

bogdanm · 2014-11-06T10:54:47Z

Hello,

There are still some things to fix (mainly in the build system), but the pull request looks good enough for merging now (and the USB library compiles fine).. Thanks for addressing my comments.

Bogdan

[RZ/A1H] mbed-RZ first release

[RZ/A1H] mbed-RZ first release

b78ac75

including - mbed cmsis for RZ/A1H - mbed hal for RZ/A1H - GPIO, Timer, I2C, SPI, InterruptIn - CA9 related files - RTOS support files for RZ/A1H

tkuro-rel added 9 commits October 24, 2014 10:14

Revert "[RZ/A1H] mbed-RZ first release"

c7c1613

This reverts commit b78ac75.

Merge remote-tracking branch 'upstream/master'

b161a14

[RZ/A1H] commit for build system changes

b1cb82c

- add CA9 category to build.py - add library for RTX-CA9 - add target definition for RZ/A1H - change some test related settings for RZ/A1H - add gcc options for CA9

[RZ/A1H] commit for CMSIS changes

193bdaa

- adds CA9 related headers - adds start up routine (only ARMCC is supported) - adds scatter file for RZ/A1H - adds GIC driver - adds peripheral definitions(iodefine) for RZ/A1H - adds serial flash boot loader for RZ/A1H

[RZ/A1H] commit for HAL changes

9ddce12

- adds GPIO driver - adds I2C driver - adds SPI driver - adds PWM driver - adds serial driver (irq not supported) - adds ticker driver - add analogin driver

[RZ/A1H] commit for RTOS changes

b024a3d

- adds RTX-CA related files - changes Thread.cpp for CA9 - adds GR-PEACH entry to README.md

[RZ/A1H] fixs scatter file

55ddb7f

There was two sections for sflash which lead to separate output .bin file. Fixed.

[RZ/A1H] first release - change InterruptManager.cpp for CA9

cff29fd

RZ/A1H has GIC instead of NVIC. InterruptManger assumes NVIC only, so temporarily ifdef guarded in order to pass the compilation.

[RZ/A1H] adds A9 related MACROS

2804d85

AMANUMA Kazuhisa added 2 commits October 24, 2014 17:20

Supports the CDC of USB function

c713db8

Revert "Supports the CDC of USB function"

8087cf1

This reverts commit c713db8.

AMANUMA Kazuhisa added 2 commits October 24, 2014 18:06

[RZ/A1H] updates iodefine.h

b5cd75c

[RZ/A1H] Supports the CDC of USB Function

462a657

AMANUMA Kazuhisa and others added 7 commits October 29, 2014 10:38

[RZ/A1H] Revert a macro line

a52058e

Merge remote-tracking branch 'upstream/master'

b8809b3

Deleted the debug print and the illegal memory access.

6aaae4a

Merge remote-tracking branch 'origin/master'

697dfdd

Revert "Deleted the debug print and the illegal memory access."

3f32994

This reverts commit 6aaae4a.

[RZ/A1H] Deletes debugging prints. Expands the stacks and heap. Delet…

e8b0bd2

…es the illegal memory access

[RZ/A1H] disables GCC_ARM in targets.py

807f031

GCC is not supported by now, so eliminate GCC_ARM in targets.py and fpu related settings in toolchains/gcc.py

Add Ethernet functionality

9a8a75e

Although the Ethernet functionality is not for review.

AMANUMA Kazuhisa and others added 9 commits November 5, 2014 14:25

[RZ/A1H] * Some fields for RZ/A1H changed as "private". * Some functi…

d517c28

…on moved into USBHAL_RZA1H.cpp. * Interrupts registration routine returned to the original sample code.

[RZ/A1H] Deletes the tab codes

3197246

[RZ/A1H] changes copy scheme for iodefines/iobitmasks

2fab4af

RZ's toolchain assumes that iodefines/iobitmasks dirs. are structured real not flat. Adds some code to toolchain::copy_files

Merge branch 'master' of https://github.com/tkuro-rel/mbed

26e1fc8

Revert "[RZ/A1H] changes copy scheme for iodefines/iobitmasks"

a95f453

This reverts commit 2fab4af.

[RZ/A1H] changes copy scheme for iodefines/iobitmasks

56c838a

RZ's toolchain assumes that iodefines/iobitmasks dirs. are structured real not flat. Adds some code to toolchain::copy_files

Merge remote-tracking branch 'origin'

19ca580

[RZ/A1H] test message

dcca0bf

- some topics - subsub toppics

Revert "[RZ/A1H] test message"

abf47c0

This reverts commit dcca0bf.

bogdanm added the needs: work label Nov 5, 2014

AMANUMA Kazuhisa and others added 5 commits November 6, 2014 10:14

Merge commit '2fab4af9b1a3d149ba4afc535744d4442a281cf8'

3c4067a

Merge remote-tracking branch 'origin/master'

f89144d

[RZ/A1H] (a measure devised to deal with a review.) * Some variables …

b5103bd

…in USBHAL.h moved into USBHAL_RZ_A1H.cpp. * Some functions writing by c++ changed to macro function.

Fixed file header

bd79e23

Fixed copyright and correction of erroneous description.

Merge remote-tracking branch 'upstream/master'

33a843c

Conflicts: workspace_tools/targets.py

bogdanm added a commit that referenced this pull request Nov 6, 2014

Merge pull request #594 from tkuro-rel/master

8724eb6

[RZ/A1H] mbed-RZ first release

bogdanm merged commit 8724eb6 into ARMmbed:master Nov 6, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RZ/A1H] mbed-RZ first release #594

[RZ/A1H] mbed-RZ first release #594

tkuro-rel commented Oct 23, 2014

bogdanm commented Oct 23, 2014

tkuro-rel commented Oct 23, 2014

tkuro-rel commented Oct 24, 2014

tkuro-rel commented Oct 24, 2014

0xc0170 commented Oct 24, 2014

tkuro-rel commented Oct 24, 2014

bogdanm commented Oct 24, 2014

tkuro-rel commented Oct 29, 2014

masaohamanaka-zz commented Oct 31, 2014

0xc0170 commented Oct 31, 2014

masaohamanaka-zz commented Oct 31, 2014

bogdanm commented Nov 3, 2014

tkuro-rel commented Nov 6, 2014

bogdanm commented Nov 6, 2014

[RZ/A1H] mbed-RZ first release #594

[RZ/A1H] mbed-RZ first release #594

Conversation

tkuro-rel commented Oct 23, 2014

bogdanm commented Oct 23, 2014

tkuro-rel commented Oct 23, 2014

tkuro-rel commented Oct 24, 2014

tkuro-rel commented Oct 24, 2014

0xc0170 commented Oct 24, 2014

tkuro-rel commented Oct 24, 2014

bogdanm commented Oct 24, 2014

tkuro-rel commented Oct 29, 2014

masaohamanaka-zz commented Oct 31, 2014

0xc0170 commented Oct 31, 2014

masaohamanaka-zz commented Oct 31, 2014

bogdanm commented Nov 3, 2014

tkuro-rel commented Nov 6, 2014

bogdanm commented Nov 6, 2014