Nanostack release v704 #5602

artokin · 2017-11-28T12:06:24Z

Description

Nanostack v7.0.4 release for mbed-os-5.7

-Apache license added to files that were missing it
-Obsolete files removed

Libraries updated:

features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack
features/nanostack/FEATURE_NANOSTACK/coap_service

Status

READY

* commit '6887e495f0cb0b3009e4da7c0282c1542bbb2608': Squashed 'features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack/' changes from 0a5ef1c..0697d9a

…changes from 0a5ef1c..0697d9a 0697d9a Remove Jenkinsfile and .gitmodules f983190 Merge branch 'release_internal' into release_external 86c0f98 Nanostack v7.0.3 release corrections (ARMmbed#1491) git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack git-subtree-split: 0697d9a

… from b1c9efb..471121d 471121d Update apache license (ARMmbed#84) 7cb9f65 Enable COAP traces in Linux builds (ARMmbed#82) git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service git-subtree-split: 471121d

* commit 'f5265c3d2083333276909cf7b16c89657aa7d58a': Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes from b1c9efb..471121d

0xc0170 · 2017-11-28T12:10:08Z

@artokin Thanks, we will review it shortly

0xc0170 · 2017-11-28T13:59:01Z

One question - https://github.com/ARMmbed/mbed-os/tree/70e7b40468854d33431889a9cd415364c00a2501/features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack - all the files in the root are relevant (makefiles, scripts, .git files)

adbridge

@artokin
The following points need addressing before this is considered suitable for 5.7 release:

Why is the structure:
features/nanostack/FEATURE_NANOSTACK

instead of just
features/FEATURE_NANOSTACK ??
clone_nanostack.sh

Should this be in the mbed-os repo? If so should it have a licence header ?
coap_service

a) Should the .sh, makefile etc files have licence headers ? Should these files even be here ?
b) How are the tests compiled and run? If these are to remain here and public then there should be documentation on how to run them ...
/mbed-mesh-api/test/6lowpan_nd

This mentions yotta as a requirement - is this still correct? This is deprecated from mbed-os so is going to send mixed messages? Do these test instructions actually work when run from mbed-os clone ?
sal-stack-nanostack

Also has a huge set of unit tests in two different folders. Do we really want them here and if so there needs to be instructions on running them and licence headers in files accordingly...

General comment: We are not happy to take all the test code as it currently stands, if you do not have time to bring all that up to scratch including the running instructions prior to Thursday's release deadline, can i suggest that all the test code is removed ? It can always be added again at a later date when ready..

artokin · 2017-11-28T15:50:46Z

@0xc0170, Makefile and scripts are needed to execute unit tests. git-files are there like in the other "git-subtree" released components (coap-service, mbed-trace, etc).

0xc0170 · 2017-11-28T15:51:56Z

Makefile and scripts are needed to execute unit tests

OK then if we are keeping them, have similar question to Anna, will wait for the answer to those.

artokin · 2017-11-28T16:23:57Z

@adbridge, thanks for the comments.

The structure is features/nanostack/FEATURE_NANOSTACK as we replaced sal-stack-nanostack binary content with source content. No component restructuring was made.
clone_nanostack.sh is obsolete and it is removed
coap_service has been part of mbed-os quite a long time. We haven't restructured this folder now.
a) We can add license headers to makefiles and scripts. They are needed for executing unit tests. I'll make a fix commit for this.
b) test execution instructions are needed (TBD)
/mbed-mesh-api/test/6lowpan_nd was not updated in this PR. It contains old instructions that needs to be cleaned. Will be solved in ONME-3307
sal-stack-nanostack contains similar unit tests like coap-service. Test execution instructions (TBD) are missing just like in the coap-service.

@mikter and @TuomoHautamaki, how do we proceed with the unit tests? Any suggestions?

SeppoTakalo · 2017-11-28T19:49:15Z

I would actually propose not to modify any of those Makefiles, etc. that are from original repository.
I the future we are planning to update Nanostack by using git subtree --pull so any local modifications can ruin it or make merging harder.

If this is not acceptable, then probably all the Makefiles and unittests have to be gone. Makes no sense to keep Makefiles just for unittests because no modifications to stack would be accepted here. All testing is to be done against the master copy of Nanostack's repository.

Therefore, either remove all that is not relevant to Mbed OS, or keep structure intact for purpose of helping merges.

… from 471121d..29bfb78 29bfb78 Add apache license to Makefiles and scripts (ARMmbed#85) git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service git-subtree-split: 29bfb78

…k_release_v704 * commit 'f900accac5b4efc426e0c2889e78ed9cd8de9b68': Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes from 471121d..29bfb78

artokin · 2017-11-29T08:11:36Z

Previous commit will fix item 3a, license headers added to makefiles and scripts in coap-service

TuomoHautamaki · 2017-11-29T08:49:54Z

Please note that there are already released components including similar unit tests in mbed OS which need the same guidelines (coap-service, libservice, mbed-client-randlib).

In short term enabling release testing and helping merges seen more crucial than temporarily removing nanostack tests due to missing guidelines.

Fully agree the need to have proper documentation for the unit tests. We will take action to solve this issue with coap-service, libservice, mbed-client-randlib and nanostack libraries but it will not be ready for mbed OS 5.7.

0xc0170 · 2017-11-29T10:42:49Z

Fully agree the need to have proper documentation for the unit tests. We will take action to solve this issue with coap-service, libservice, mbed-client-randlib and nanostack libraries but it will not be ready for mbed OS 5.7.

Understood, thus our proposal is as below.

Therefore, either remove all that is not relevant to Mbed OS, or keep structure intact for purpose of helping merges.

@SeppoTakalo +1.
We should not bring more tests that are not active, no documentation. We should keep them out from here until they are functional, tested, and have documentation. This will come as new pull request. This should happen today to get this patch ready. If any more questions , lets discuss it.

The rest of the tests in the repository will be taken care of separately. This scope is for nanostack, so lets focus about nanostack and its unittest or scripts within.

0xc0170 · 2017-11-29T13:53:29Z

@tommikas Can you please review the history of jenkins CI , are there any problems today we should be aware?

…changes from 0697d9a..c9bf20f c9bf20f Remove test and unittest folders git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack git-subtree-split: c9bf20f

…k_release_v704 * commit '041b6fa73681061072f970e9cf11ff4d422fa04b': Squashed 'features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack/' changes from 0697d9a..c9bf20f

sg- · 2017-11-30T05:47:55Z

Why is Nanostack still in a FEATURE_ directory? I'd expected this would always be part of the build now...

So feature/nanostack/ Soon all FEATURE_ will be gone and we can move these to the root level like /networking/

artokin · 2017-11-30T08:15:44Z

@sg- , we still like to use existing FEATURE-configuration to include/exclude Nanostack from the application build. This ensures that existing applications are still working without surprises.

sg- · 2017-11-30T08:19:36Z

When will that change and be part of the default build?

TuomoHautamaki · 2017-11-30T08:32:49Z

@sg- I'll contact you to discuss more about this future change. Not in the scope of this release.

artokin · 2017-11-30T09:04:35Z

Unit tests are now removed from Nanostack. All items should be solved now (unit tests in other components will be addressed separately).

0xc0170 · 2017-11-30T10:38:40Z

/morph build

mbed-ci · 2017-11-30T11:23:11Z

Build : SUCCESS

Build number : 625
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5602/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-30T12:53:17Z

Exporter Build : SUCCESS

Build number : 252
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5602/

mbed-ci · 2017-11-30T12:56:12Z

Test : SUCCESS

Build number : 447
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5602/447

Arto Kinnunen added 6 commits November 28, 2017 09:45

Remove obsolete clone_nanostack script

0c041b9

Add apache license to nanostack-interface

97cf886

Merge commit '6887e495f0cb0b3009e4da7c0282c1542bbb2608'

fc6aeb9

* commit '6887e495f0cb0b3009e4da7c0282c1542bbb2608': Squashed 'features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack/' changes from 0a5ef1c..0697d9a

Merge commit 'f5265c3d2083333276909cf7b16c89657aa7d58a'

ac4fae8

* commit 'f5265c3d2083333276909cf7b16c89657aa7d58a': Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes from b1c9efb..471121d

0xc0170 added the needs: review label Nov 28, 2017

0xc0170 requested a review from adbridge November 28, 2017 12:09

0xc0170 requested review from SeppoTakalo and mikter November 28, 2017 12:14

mikter approved these changes Nov 28, 2017

View reviewed changes

adbridge requested changes Nov 28, 2017

View reviewed changes

Arto Kinnunen added 2 commits November 29, 2017 09:41

Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes…

f900acc

… from 471121d..29bfb78 29bfb78 Add apache license to Makefiles and scripts (ARMmbed#85) git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service git-subtree-split: 29bfb78

Merge commit 'f900accac5b4efc426e0c2889e78ed9cd8de9b68' into nanostac…

0413253

…k_release_v704 * commit 'f900accac5b4efc426e0c2889e78ed9cd8de9b68': Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes from 471121d..29bfb78

0xc0170 added needs: work and removed needs: review labels Nov 29, 2017

SeppoTakalo approved these changes Nov 29, 2017

View reviewed changes

Arto Kinnunen added 3 commits November 29, 2017 21:34

Squashed 'features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack/' …

041b6fa

…changes from 0697d9a..c9bf20f c9bf20f Remove test and unittest folders git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack git-subtree-split: c9bf20f

Merge commit '041b6fa73681061072f970e9cf11ff4d422fa04b' into nanostac…

32abfcf

…k_release_v704 * commit '041b6fa73681061072f970e9cf11ff4d422fa04b': Squashed 'features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack/' changes from 0697d9a..c9bf20f

Remove mbed-mesh-example and application

3252fa0

0xc0170 added needs: review and removed needs: work labels Nov 30, 2017

adbridge approved these changes Nov 30, 2017

View reviewed changes

0xc0170 approved these changes Nov 30, 2017

View reviewed changes

0xc0170 added ready for merge release-version: 5.7.0-rc1 needs: review and removed needs: review ready for merge labels Nov 30, 2017

0xc0170 requested a review from sg- November 30, 2017 18:21

sg- approved these changes Nov 30, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Nov 30, 2017

0xc0170 merged commit 41591eb into ARMmbed:master Nov 30, 2017

0xc0170 removed the ready for merge label Nov 30, 2017

artokin deleted the nanostack_release_v704 branch December 1, 2017 07:37

JanneKiiskila mentioned this pull request Dec 2, 2017

Realtek RTL8195AM - CMSIS-RTOS error: ISR Queue overflow (status: 0x2, task ID: 0x0, object ID: 0x30051484) #5640

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nanostack release v704 #5602

Nanostack release v704 #5602

artokin commented Nov 28, 2017

0xc0170 commented Nov 28, 2017

0xc0170 commented Nov 28, 2017

adbridge left a comment

artokin commented Nov 28, 2017

0xc0170 commented Nov 28, 2017

artokin commented Nov 28, 2017 •

edited

Loading

SeppoTakalo commented Nov 28, 2017

artokin commented Nov 29, 2017

TuomoHautamaki commented Nov 29, 2017

0xc0170 commented Nov 29, 2017 •

edited

Loading

0xc0170 commented Nov 29, 2017 •

edited

Loading

sg- commented Nov 30, 2017

artokin commented Nov 30, 2017

sg- commented Nov 30, 2017

TuomoHautamaki commented Nov 30, 2017

artokin commented Nov 30, 2017

0xc0170 commented Nov 30, 2017

mbed-ci commented Nov 30, 2017

mbed-ci commented Nov 30, 2017

mbed-ci commented Nov 30, 2017

Nanostack release v704 #5602

Nanostack release v704 #5602

Conversation

artokin commented Nov 28, 2017

Description

Status

0xc0170 commented Nov 28, 2017

0xc0170 commented Nov 28, 2017

adbridge left a comment

Choose a reason for hiding this comment

artokin commented Nov 28, 2017

0xc0170 commented Nov 28, 2017

artokin commented Nov 28, 2017 • edited Loading

SeppoTakalo commented Nov 28, 2017

artokin commented Nov 29, 2017

TuomoHautamaki commented Nov 29, 2017

0xc0170 commented Nov 29, 2017 • edited Loading

0xc0170 commented Nov 29, 2017 • edited Loading

sg- commented Nov 30, 2017

artokin commented Nov 30, 2017

sg- commented Nov 30, 2017

TuomoHautamaki commented Nov 30, 2017

artokin commented Nov 30, 2017

0xc0170 commented Nov 30, 2017

mbed-ci commented Nov 30, 2017

Build : SUCCESS

Triggering tests

mbed-ci commented Nov 30, 2017

Exporter Build : SUCCESS

mbed-ci commented Nov 30, 2017

Test : SUCCESS

artokin commented Nov 28, 2017 •

edited

Loading

0xc0170 commented Nov 29, 2017 •

edited

Loading

0xc0170 commented Nov 29, 2017 •

edited

Loading