-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing device_name for targets with bootloader #5253
Conversation
@amq Please look at travis, fails because of not valid device name? |
@0xc0170 this looks like a broader issue with It is not possible to inherit from |
@amq Are these MCU published in the cmsis pack database? Travis fails still. |
@amq bump |
1 similar comment
@amq bump |
@0xc0170 sorry for not being clear enough. There is a problem beyond this PR (blocker), which makes it impossible to inherit from To my understanding this is clearly a bug and we should probably get help from Silicon Labs people. |
@amq Thanks, I am still not getting the full picture, I'll talk to Steven about this.
@stevew817 Can you please help ? |
EFR32MG1_BRD4150 is not marked as public because the board doesn't have USB MSD for programming. Also, it would make a bad mbed target since the kit costs hundreds of $. I'm still unclear on what exactly the issue is here? |
Alright, I've removed the |
/morph build |
Build : SUCCESSBuild number : 510 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 125 |
As already referenced, #5470 the same failure different device. There is a proposed fix in the latest comment there |
/morph test |
Test : SUCCESSBuild number : 334 |
Now that CI passed on #5470, could we restart it here? |
/morph build |
Build : FAILUREBuild number : 712 |
/morph build |
Build : SUCCESSBuild number : 714 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 366 |
Test : SUCCESSBuild number : 543 |
Once this PR gets in, we will restart CI |
/morph export-build |
Exporter Build : FAILUREBuild number : 408 |
/morph export-build |
Exporter Build : FAILUREBuild number : 417 |
Looking into since error is similar to #5470 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 435 |
Some EFM32 targets with bootloader support are missing the required
device_name
. This PR fixes it using an analogy to other targets.Notes:
Status
READY
Migrations
NO