Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing device_name for targets with bootloader #5253

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Add missing device_name for targets with bootloader #5253

merged 1 commit into from
Jan 4, 2018

Conversation

amq
Copy link
Contributor

@amq amq commented Oct 4, 2017

Some EFM32 targets with bootloader support are missing the required device_name. This PR fixes it using an analogy to other targets.

Notes:

Status

READY

Migrations

NO

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2017

@amq Please look at travis, fails because of not valid device name?

@amq
Copy link
Contributor Author

amq commented Oct 8, 2017

@0xc0170 this looks like a broader issue with EFR32MG1. Probably that's also why EFR32MG1_BRD4150 is marked with public: false. Relevant PR: #3157
@stevew817

It is not possible to inherit from EFR32MG1
EFR32MG1P132F256GM48
EFR32MG1P233F256GM48
... without either removing device_name from parent or without adding public: false to child.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 9, 2017

EFR32MG1P132F256GM48
EFR32MG1P233F256GM48

@amq Are these MCU published in the cmsis pack database? Travis fails still.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2017

@amq bump

1 similar comment
@adbridge
Copy link
Contributor

@amq bump

@amq
Copy link
Contributor Author

amq commented Oct 24, 2017

@0xc0170 sorry for not being clear enough. There is a problem beyond this PR (blocker), which makes it impossible to inherit from EFR32MG1P132F256GM48 and EFR32MG1P233F256GM48. It was most likely introduced in #3157

To my understanding this is clearly a bug and we should probably get help from Silicon Labs people.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2017

@amq Thanks, I am still not getting the full picture, I'll talk to Steven about this.

@0xc0170 sorry for not being clear enough. There is a problem beyond this PR (blocker), which makes it impossible to inherit from EFR32MG1P132F256GM48 and EFR32MG1P233F256GM48. It was most likely introduced in #3157

@0xc0170 this looks like a broader issue with EFR32MG1. Probably that's also why EFR32MG1_BRD4150 is marked with public: false. Relevant PR: #3157

@stevew817 Can you please help ?

@stevew817
Copy link
Contributor

EFR32MG1_BRD4150 is not marked as public because the board doesn't have USB MSD for programming. Also, it would make a bad mbed target since the kit costs hundreds of $.

I'm still unclear on what exactly the issue is here?

@amq
Copy link
Contributor Author

amq commented Oct 25, 2017

Alright, I've removed the EFR32MG1 modification from the commit, it now fixes the missing device_name only in EFM32PG12 and EFR32MG12.

@theotherjimmy
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 13, 2017

Build : SUCCESS

Build number : 510
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5253/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 13, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2017

As already referenced, #5470 the same failure different device. There is a proposed fix in the latest comment there

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2017

@amq
Copy link
Contributor Author

amq commented Dec 17, 2017

Now that CI passed on #5470, could we restart it here?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

Build : FAILURE

Build number : 712
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5253/

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

Build : SUCCESS

Build number : 714
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5253/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2017

Now that CI passed on #5470, could we restart it here?

Once this PR gets in, we will restart CI

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

@cmonr
Copy link
Contributor

cmonr commented Dec 28, 2017

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 28, 2017

@cmonr
Copy link
Contributor

cmonr commented Dec 28, 2017

Looking into since error is similar to #5470

@cmonr cmonr self-assigned this Dec 28, 2017
@studavekar
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2018

Exporter Build : SUCCESS

Build number : 435
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5253/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants