Realtek_RTL8195AM fix for debug profile #5044

Archcady · 2017-09-07T03:18:40Z

Previously Realtek_RTL8195AM is unable to run with debug profile, now the issue is resolved. Changes are:
Change MSP setting method in booting;
Update wlan libs to fix a mutex osErrorISR issue;
Increase tcpip thread stacksize;

Related PR:
#4665

Use asm code to set MSP

The issue of mutex returning osErrorISR with debug profile is fixed

The default stack size is not enough for debug profile (low compiler optimization)

Clean rtl8195a_init.c a little bit

Archcady · 2017-09-07T07:15:58Z

Hi @marcuschangarm , we fix the issue with debug profile with GCC on windows. I'm not sure if the issue with ARMCC/Linux is fixed since we don't have the compiler. Would you please give this PR a quick test? Many thanks.

bulislaw

LGTM

marcuschangarm · 2017-09-07T11:08:58Z

@Archcady Thank you for the fix. My test app is currently too large when using debug profile, so it might take me some time to shrink the test app enough to test this.

0xc0170 · 2017-09-08T12:32:08Z

@Archcady Thank you for the fix. My test app is currently too large when using debug profile, so it might take me some time to shrink the test app enough to test this.

Any estimate?

marcuschangarm · 2017-09-08T14:44:22Z

Well, good news, bad news. 😄

I'm not seeing the problems I saw when compiling with debug profile. So thats great!

Overall, I'm still seeing a lot of instability issues. My TLS client test connects successfully 50% of the time, the other times it fails on a socket error.

When I run my large application, it crashes at random places.

I'm also seeing this odd warning when linking:

Link: tls-client
Elf2Bin: tls-client
Malformed input found when parsing GCC map: linker stubs
Malformed input found when parsing GCC map: linker stubs

Archcady · 2017-09-11T05:47:14Z

Hi @marcuschangarm , those strange messages (Malformed input found when parsing GCC map: linker stubs) are coming from mbed-os\tools\memap.py. Looks like the MemapParser could not parse all the lines in .map file. The same messages are found when compile with ARMCC.

Remove intermediate variances and use uint64 instead; Remove HalTimerIrqEn called in us_ticker.c

Archcady · 2017-09-15T11:02:49Z

Hi @marcuschangarm , with this new commit, mbed-cloud-client-example-r-confidential is much stable now. I ran it for at least one hour without crash or hanging.

marcuschangarm · 2017-09-15T19:55:10Z

Thank you! That is great news! I'm currently traveling, but I'll try it out as soon as I get back!

adbridge · 2017-09-18T14:53:58Z

/morph test-nightly

mbed-bot · 2017-09-18T18:41:54Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

studavekar · 2017-09-19T01:56:16Z

/morph test-nightly

mbed-bot · 2017-09-19T07:32:36Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1338

All builds and test passed!

adbridge · 2017-09-19T09:27:53Z

@0xc0170 there was another change since you last reviewed, could you take a quick re-review?

adbridge

A couple of minor coding style issues which should be fixed in any subsequent PR but not going to block this one on them.

adbridge · 2017-09-19T09:39:22Z

targets/TARGET_Realtek/TARGET_AMEBA/us_ticker.c

@@ -23,24 +23,33 @@
 #define SYS_TIM_ID      1   // the G-Timer ID for System
 #define APP_TIM_ID      6   // the G-Timer ID for Application

+#define TICK_TO_US(x)     (uint64_t)(((x)/2) * 61 + ((x)%2) * TIMER_TICK_US)


An explanation of where '61' comes from would be useful here

@adbridge Clock source is 32K, therefore, us per tick is 30.5. The TICK_TO_US macro is basically: (tick / 2) * (30.5*2) + residue

This patch is basically broken. I have submitted another PR #5143 to address us ticker issue, and also added proper inline comment.

adbridge · 2017-09-19T09:40:38Z

targets/TARGET_Realtek/TARGET_AMEBA/us_ticker.c

 }

 void us_ticker_init(void) 
 {

-    if (us_ticker_inited) return;
+    if (us_ticker_inited){


space required before '{'

Also fixed in #5143

Archcady added 4 commits September 7, 2017 10:58

Update MSP setup

1d6a69b

Use asm code to set MSP

Update wlan lib to fix debug profile

2642ab3

The issue of mutex returning osErrorISR with debug profile is fixed

Increase tcpip thread stacksize for REALTEK_RTL8195AM

22269ad

The default stack size is not enough for debug profile (low compiler optimization)

Remove unused code

ba3bb7e

Clean rtl8195a_init.c a little bit

0xc0170 added the needs: review label Sep 7, 2017

0xc0170 approved these changes Sep 7, 2017

View reviewed changes

bulislaw approved these changes Sep 7, 2017

View reviewed changes

Re-work Rtl8195AM ticker

f7bc126

Remove intermediate variances and use uint64 instead; Remove HalTimerIrqEn called in us_ticker.c

samchuarm mentioned this pull request Sep 17, 2017

General instability on REALTEK_RTL8195AM (GCC_ARM) ARMmbed/mbed-os-example-client#306

Closed

adbridge added the release-version: 5.6.0-rc2 label Sep 18, 2017

theotherjimmy added needs: CI and removed needs: review labels Sep 18, 2017

adbridge mentioned this pull request Sep 18, 2017

[OOB 5.6] Blinky failed to build on REALTEK_RTL8195AM (ARMC5, GCC, IAR, online compiler) #5126

Closed

adbridge approved these changes Sep 19, 2017

View reviewed changes

adbridge merged commit 003dd7c into ARMmbed:master Sep 19, 2017

adbridge removed the needs: CI label Sep 19, 2017

tung7970 mentioned this pull request Sep 20, 2017

RTL8195AM - Fix us_ticker porting #5143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Realtek_RTL8195AM fix for debug profile #5044

Realtek_RTL8195AM fix for debug profile #5044

Archcady commented Sep 7, 2017 •

edited

Loading

Archcady commented Sep 7, 2017

bulislaw left a comment

marcuschangarm commented Sep 7, 2017

0xc0170 commented Sep 8, 2017

marcuschangarm commented Sep 8, 2017

Archcady commented Sep 11, 2017

Archcady commented Sep 15, 2017

marcuschangarm commented Sep 15, 2017

adbridge commented Sep 18, 2017

mbed-bot commented Sep 18, 2017

studavekar commented Sep 19, 2017

mbed-bot commented Sep 19, 2017

adbridge commented Sep 19, 2017

adbridge left a comment

adbridge Sep 19, 2017

tung7970 Sep 20, 2017

adbridge Sep 19, 2017

tung7970 Sep 20, 2017

Realtek_RTL8195AM fix for debug profile #5044

Realtek_RTL8195AM fix for debug profile #5044

Conversation

Archcady commented Sep 7, 2017 • edited Loading

Archcady commented Sep 7, 2017

bulislaw left a comment

Choose a reason for hiding this comment

marcuschangarm commented Sep 7, 2017

0xc0170 commented Sep 8, 2017

marcuschangarm commented Sep 8, 2017

Archcady commented Sep 11, 2017

Archcady commented Sep 15, 2017

marcuschangarm commented Sep 15, 2017

adbridge commented Sep 18, 2017

mbed-bot commented Sep 18, 2017

Result: ABORTED

studavekar commented Sep 19, 2017

mbed-bot commented Sep 19, 2017

Result: SUCCESS

Output

adbridge commented Sep 19, 2017

adbridge left a comment

Choose a reason for hiding this comment

adbridge Sep 19, 2017

Choose a reason for hiding this comment

tung7970 Sep 20, 2017

Choose a reason for hiding this comment

adbridge Sep 19, 2017

Choose a reason for hiding this comment

tung7970 Sep 20, 2017

Choose a reason for hiding this comment

Archcady commented Sep 7, 2017 •

edited

Loading