[nrf51822][gcc_arm]: fix makefile templates and nrf_svc.h's 'impossible constraint in asm' error #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,4 +54,4 @@ $(PROJECT).hex: $(PROJECT).elf | |||
| $(OBJCOPY) -O ihex $< $@ | |||
|
|
|||
| merge: | |||
| $(SREC_CAT) $(SOFTDEVICE) -intel $(PROJECT).hex -intel --offset 0x16000 -o combined.hex -intel --line-length=46 | |||
| $(SREC_CAT) $(SOFTDEVICE) -intel $(PROJECT).hex -intel -o combined.hex -intel --line-length=44 | |||
There was a problem hiding this comment.
Out of curiosity, why did you change the line length?
There was a problem hiding this comment.
To be consistent with the length of uvision's hex file
bogdanm
added a commit
that referenced
this pull request
Sep 5, 2014
[nrf51822][gcc_arm]: fix makefile templates and nrf_svc.h's 'impossible constraint in asm' error
1 task
sg-
added a commit
that referenced
this pull request
Apr 6, 2017
Fix mbed-cli issue #468. Add LPCTargetCode.lpc_patch to POST_BINARY_WHITELIST
adbridge
pushed a commit
that referenced
this pull request
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update softdevice path in makefile. The file structue of online compiler projects is different with projects exported by project.py. this is for online compiler.
The offset param of srec_cat should not be used with hex file in this case, as hex file contains address info.
I tested '-Os' option again. It's OK now. It may be a problem of mine. I don't know why : (