Update CMSIS-Core and RTX to version 5 #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2017
3 tasks
|
FYI, building for the EFM32GG_STK3700 target generates new warnings with this branch. |
|
retest uvisor |
1 similar comment
|
retest uvisor |
|
Merged with master so CI can be run again |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@c1728p9 makes sense, thanks! |
bridadan
suggested changes
May 15, 2017
There was a problem hiding this comment.
@bulislaw There are still a mountain of warnings that are making the build times go through the roof for a number of targets: http://mbed-ci-master-2.austin.arm.com:8081/job/build_matrix/197/target=NUCLEO_F103RB,toolchain=GCC_ARM/console
That target went from taking ~10 seconds to ~9 minutes.
For your reference, here are the 3 targets that are problematic:
9 min 4 sec, build_matrix/target=NUCLEO_L152RE,toolchain=GCC_ARM #197
9 min 3 sec, build_matrix/target=XDOT_L151CC,toolchain=GCC_ARM #197
8 min 47 sec, build_matrix/target=NUCLEO_F103RB,toolchain=GCC_ARM #197
|
And just because data is cool, here's a current list of all build times for this PR 😄 |
|
Merged master into CMSIS_5 so it is up to date |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
Thanks @bridadan I'll have a look, I know there was some noise from IAR warnings, but didn't know about GCC. |
|
/morph test-nightly |
|
The macros that I'm removing from target code weren't defined by the old CMSIS. |
|
Also let's not try to split CMSIS and RTX as it's just generating confusion and uncertainty with tests and quality rather than progressing things towards master. |
geky
reviewed
May 16, 2017
| @@ -8631,58 +8631,24 @@ typedef struct | |||
|
|
|||
| /******************* Bit definition for SCB_CFSR register *******************/ | |||
| /*!< MFSR */ | |||
| #define SCB_CFSR_IACCVIOL_Pos (0U) | |||
| #define SCB_CFSR_IACCVIOL_Msk (0x1U << SCB_CFSR_IACCVIOL_Pos) /*!< 0x00000001 */ | |||
There was a problem hiding this comment.
So these are defined by cmsis/rtx?
Is it normal for the rtos to define target-specific registers? Just curious
There was a problem hiding this comment.
Yeah, they are defined by CMSIS-Core. And ARM Core registers are sort of fixed in memory map afaik http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0552a/Cihcfefj.html
|
@bulislaw I don't think the CI is doing anything wrong here (besides Jenkins generally being a bit sluggish). It takes time to print output to the console, and the log size increased from 651KB to 20MB. That's a 30x increase in log size. 10 seconds * 30 = 5 mins. I realize it might not scale 100% linearly (and it obviously isn't), but there will definitely be an appreciable increase in run time. |
This should be fixed as soon as client and its dependencies are updated to resolve conflicts there. We expect this to be reverted asap.
|
mbed_hal-lp_ticker.tests-mbed_hal-lp_ticker – failing on k22f and k64f |
|
/morph test-nightly |
|
Need to reduce 168 bytes from |
|
/morph test-nightly |
JanneKiiskila
pushed a commit
to ARMmbed/mbed-os-example-client
that referenced
this pull request
Jun 2, 2017
Point the libs to pal.lib PR having the CMSIS support and mbed OS lib to the CMSIS branch (ARMmbed/mbed-os#4294).
|
/morph test-nightly |
1 similar comment
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@bulislaw @bridadan @sg- @0xc0170 @bcostm @jeromecoutant |
|
Yes, not easy to find the exact faulty commit as all commit can not be compiled... :-( |
The test above did not uncover any issue for STM32 devices. I'll test some devices, just run any test to get this timeout? Please create an issue with details |
|
We're facing timeout with any test so far indeed. |
|
OK, I run,no issues. lets discuss this in the new issue, but we havent seen any regression so far. |
|
ok sounds good thanks |
|
Did you upgrade something on your PC: tool chain, packages, python, ....? |
I havent. You can describe in the issue your environment (all of these versions that you use). However timeouts should not be there |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main changes made by this PR:
NVIC_SetVectorandNVIC_GetVectorfrom target code as it's provided by CMSISStatus
IN DEVELOPMENT
Related PRs
List related PRs against other branches:
Todos