Add error check in Stream constructor #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMESTM
changed the title
geky
reviewed
May 2, 2017
platform/Stream.cpp
Outdated
| if (_file) | ||
| mbed_set_unbuffered_stream(_file); | ||
| else | ||
| error("Stream obj failure, errno=%d\r\n"); |
There was a problem hiding this comment.
Should this be taking in errno?
geky
reviewed
May 2, 2017
platform/Stream.cpp
Outdated
| @@ -23,7 +25,10 @@ Stream::Stream(const char *name) : FileLike(name), _file(NULL) { | |||
| char buf[12]; /* :0x12345678 + null byte */ | |||
| std::sprintf(buf, ":%p", this); | |||
| _file = std::fopen(buf, "w+"); | |||
| mbed_set_unbuffered_stream(_file); | |||
| if (_file) | |||
There was a problem hiding this comment.
Small nit if you're already changing the file: We use squiggly brackets on single line if statement:
if (_file) {
blah
} else {
bleh
}There was a problem hiding this comment.
ok will take also into account - thx !
geky
approved these changes
May 2, 2017
failing on file allocation / opening during Stream creation. The consequence was application continues running, but any printf to the Serial object whose Stream was not properly created would not show any error (and characters would not show either) Let's add a check to properly inform user of the error.
LMESTM
force-pushed
the
fix_Stream_issue687
branch
from
dbf3b20
to
4ad4b2a
Compare
|
@geky thx for the comments - I pushed an updated version of the patch |
|
Thanks! This looks great! 😄 |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Restarting /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
May 4, 2017
|
This is reliant on #3867 which is targeted for 5.5.0 thus re-targeting this one also for 5.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal following discussion on #687
Description
On small targets there might be memory issues that lead to failing on file allocaiton / opening during Stream creation.
The consequence was application continues running, but any printf
to the Serial object whose Stream was not properly created
would not show any error (and characters would not show either)
Let's add a check to be properly inform user of the error.
Status
READY