-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform] Update doxygen comments #4233
Conversation
match the arguments
This is required to allow doxygen to properly parse the function declarations, otherwise it gets confused around the nested templates.
The best magic I could come up with was to just move the sfinae logic out into a macro that doxygen ignores. It seems like doxygen was having issues with the nested templates? |
Still needs work? No error anymore? |
@0xc0170 You are correct, it no longer needs work, and may be marked ready for review. Thanks for the bump. |
Pulled the change and looks to still have the same problem
|
Oh! @sg- did we add the macro to the doxygen config as well? - "PREDEFINED": "DOXYGEN_ONLY \"MBED_DEPRECATED_SINCE(f, g)=\"",
+ "PREDEFINED": "DOXYGEN_ONLY \"MBED_DEPRECATED_SINCE(f, g)=\" \"MBED_ENABLE_IF_CALLBACK_COMPATIBLE(F, M)=\"", |
Macro used to eliminate nested template which doxygen has a problem with.
@geky Good catch. OK this looks good now.
|
This PR relies on changes introduced in #3867 which is targeted for 5.5.0 , thus re-targeting this one also to 5.5.0 |
Description
Fix warnings and errors when building API docs in the mbed-os/platform directory using doxygen. Still a rouge warning that I haven't yet gotten to the bottom of but other eyes are welcome. Doxyfile attached that is used to build this (matches the developer site settings)
doxyfile-developer.txt
Status
IN DEVELOPMENT