Only link in LPC17xx ethernet ISR as needed #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally the ethernet ISR would be linked in to all mbed-os based firmware because it was named ENET_IRQHandler() so that it would be automatically placed in the FLASH image's interrupt vector table. This meant that programs which made no use of the lwIP stack still pulled in this ISR. This commit changes the name of the routine so that the ISR isn't automatically placed in the interrupt vector table at link time but is instead dynamically placed in the interrupt vector table at runtime when the lwIP stack is initialized. Now the ethernet ISR is only linked in when it is actually needed. Example arm-none-eabi-size output for a simple LED blinking program showing the before and after size results: text data bss dec hex filename 13208 148 7784 21140 5294 LPC1768/HelloWorld.elf text data bss dec hex filename 12700 148 7468 20316 4f5c LPC1768/HelloWorld.elf
0xc0170
approved these changes
Apr 5, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild Prep failed! |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the LPC17xx ethernet ISR would be linked in to all mbed-os based
firmware because it was named ENET_IRQHandler() so that it would be
automatically placed in the FLASH image's interrupt vector table. This
meant that programs which made no use of the lwIP stack still pulled in
this ISR.
This commit changes the name of the routine so that the ISR isn't
automatically placed in the interrupt vector table at link time but is
instead dynamically placed in the interrupt vector table at runtime
when the lwIP stack is initialized. Now the ethernet ISR is only linked
in when it is actually needed.
Example arm-none-eabi-size output for a simple LED blinking program
showing the before and after size results:
text data bss dec hex filename
13208 148 7784 21140 5294 LPC1768/HelloWorld.elf
text data bss dec hex filename
12700 148 7468 20316 4f5c LPC1768/HelloWorld.elf