Raise error when mbed_app.json is bad #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is reproducible. Working on it now. |
theotherjimmy
force-pushed
the
fail-on-bad-config
branch
from
58e0096
to
8bfcbd6
Compare
|
I think I got the travis errors. |
|
/morph test |
theotherjimmy
force-pushed
the
fail-on-bad-config
branch
from
8bfcbd6
to
1faf44e
Compare
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest Prep failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Apr 1, 2017
|
@sg- merge this or? |
|
Looks like this just got missed on clicking the merge button - LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ARMmbed/mbed-cli#471
Testing