-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some type checking of configs #4000
Conversation
Before, the types were not checked and just expected. The old behavior would cause lots of tracebacks, or, much worse, convert things like: ``` { "target_overrides": { "*": { "target.macros_add": "CONFIG_GPIO_AS_PINRESET" } } } ``` into a definition of each of the letters as macros that expand to nothing, causing massive compilation problems. I resolved this by adding some type checking to the config data. Now there is a type check for most of the fields within a library and application configurations.
I got PR 4000 🎉 🎈 🍰 |
🍾 |
tools/tests/config or config_test |
@theotherjimmy Please just use the regular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Before, the types were not checked and just expected. The old behavior
would cause lots of tracebacks, or, much worse, convert things like:
into a definition of each of the letters as macros that expand to
nothing, causing massive compilation problems.
I resolved this by adding some type checking to the config data. Now
there is a type check for most of the fields within a library and
application configurations.
resolves #3985
Testing