[NRF51822] Fix reference to sleep in hal_patch override #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sleep` function as been changed into `hal_sleep` by ARMmbed#3607. Unfortunately the call to `sleep` in the hal_patch for the NRF51822 has not been updated to `hal_sleep`. The result was a link time error for targets based on NRF51822_LEGACY compiling with the mbed OS 5 tree.
|
@nvlsianpu @anangl Could you review this PR and ensure that the change in this PR is correctly reported to the NRF51822 BLE implementation on developer.mbed.org ? |
0xc0170
approved these changes
Mar 9, 2017
|
It looks properly.
Should I expected that you are going to update nRF51822 mbed 2.0 support repos? |
anangl
approved these changes
Mar 9, 2017
|
/morph test |
@nvlsianpu I think mbed 2 repo should be in line with the implementation in mbed-os. The question is who does it. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
sleepfunction as been changed intohal_sleepby #3607.Unfortunately the call to
sleepin the hal_patch for the NRF51822 has not beenupdated to
hal_sleep. The result was a link time error for targets based onNRF51822_LEGACY compiling with the mbed OS 5 tree.
Status
READY
Migrations
NO