Fix mbed 2 builds #3864

geky · 2017-03-01T21:44:50Z

Some file must have been indirectly including something that brought in size_t, since this type is notably missing from the mbed 2 builds. Fixed by including stddef.h which includes this definitions.

cc @bridadan

bridadan

Seems fine to me! I'll start the mbed 2 bot since that's what was broken

bridadan · 2017-03-01T21:58:22Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

geky · 2017-03-01T22:12:53Z

Oh! I forgot we even had that old thing.

mbed-bot · 2017-03-02T01:01:42Z

[Build 1277]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

0xc0170 · 2017-03-02T10:18:21Z

Some file must have been indirectly including something that brought in size_t, since this type is notably missing from the mbed 2 builds. Fixed by including stddef.h which includes this definitions.

I don't see that type used anywhere in retarget header file? What was the warning/error?

geky · 2017-03-02T15:50:46Z

The error was FileLike.h@48,48: [Pe020]: identifier "size_t" is undefined
http://10.118.12.43:8080/job/mbed-2-build-library/1245/testReport/build.ARCH_GPRS.IAR/MBED/mbed_SDK/

retarget.h is currently responsible for garunteeing that the normally non-portable sys types are defined (ssize_t, off_t...), so it seems reasonable to include stddef as well.

0xc0170 · 2017-03-08T12:03:08Z

@geky Can you please rebase ? Idid it locally, plus tested it. However I cant push to your fork

adbridge · 2017-03-08T12:10:42Z

NOTE: The description of this PR gives no indication that this bug broke mbed 2 for the 5.4 rc1 build. There was also no issue raised against mbed-os for which this is the fix (until I raised one today having started to prepare mbed 2 v138 for release). Thus the significance of this PR was assumed to be much lower than it actual is!! This fix SHOULD have gone into RC2 but was not prioritised due to the lack of information. This may block the mbed 2 v138 release.

geky · 2017-03-08T21:54:32Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

geky · 2017-03-08T21:54:37Z

/morph test

mbed-bot · 2017-03-08T21:55:22Z

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

bridadan · 2017-03-08T21:56:15Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-03-08T22:59:33Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1658

All builds and test passed!

mbed-bot · 2017-03-09T00:21:34Z

[Build 1286]
FAILURE: Something went wrong when building and testing.

0xc0170 · 2017-03-09T10:14:52Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

0xc0170 · 2017-03-09T10:50:14Z

Tests results look good (IAR does build now !), retriggered the CI job.

mbed-bot · 2017-03-09T12:37:50Z

[Build 1288]
FAILURE: Something went wrong when building and testing.

0xc0170 · 2017-03-09T12:39:25Z

@geky @bridadan Please look at the mbed 2 failure

0xc0170 · 2017-03-09T15:28:50Z

lpc1768 - Error: L6218E: Undefined symbol $Super$$main (referred from mbed_retarget.o)., 1288 build failure above.

geky · 2017-03-09T18:08:20Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

geky · 2017-03-09T18:13:46Z

/morph test

mbed-bot · 2017-03-09T19:17:14Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1666

All builds and test passed!

mbed-bot · 2017-03-09T19:53:07Z

[Build 1289]
FAILURE: Something went wrong when building and testing.

bridadan · 2017-03-09T20:07:57Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-03-09T22:28:35Z

[Build 1290]
FAILURE: Something went wrong when building and testing.

geky · 2017-03-10T00:12:33Z

So we tracked down the issue... it is no longer a problem in retarget, but rather a breakage that got in through mbed 2 testing while this issue was there.

Tracked down to 51aa333, @theotherjimmy is looking into the fix which we can just append to this pr.

0xc0170 · 2017-03-10T09:56:16Z

Tracked down to 51aa333, @theotherjimmy is looking into the fix which we can just append to this pr.

Thanks keep us updated.

I accidentally broke only uARM mbed 2 builds. Here is the story: When scanning for resources, toolchains look for any `TOOLCHAIN_<classname>` folders to include. These `<classname>`s mostly match the name passed in on the command line with one exception: `uARM` on the command line maps to `ARM_MICRO` the class. This would not be a problem except for the bug that I introduced in a prior commit. The bug is that the mbed2 library builds will use the name passed in on the command line to construct `TOOLCHAIN_<cli-name>`. This will not match when scanning. I fixed it by translating the `<cli-name>` into the `<classname>`.

theotherjimmy · 2017-03-10T17:17:06Z

Fixed.

theotherjimmy · 2017-03-10T17:17:11Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

geky · 2017-03-10T17:41:09Z

/morph test

mbed-bot · 2017-03-10T19:02:16Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1673

All builds and test passed!

mbed-bot · 2017-03-10T19:23:02Z

[Build 1292]
FAILURE: Something went wrong when building and testing.

bridadan · 2017-03-10T19:28:19Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-03-10T19:42:54Z

[Build 1293]
FAILURE: Something went wrong when building and testing.

bridadan · 2017-03-10T19:47:33Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-03-10T21:44:43Z

[Build 1294]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

geky · 2017-03-10T21:49:52Z

LGTM!

geky requested a review from bridadan March 1, 2017 21:45

geky added the needs: review label Mar 1, 2017

bridadan approved these changes Mar 1, 2017

View reviewed changes

0xc0170 mentioned this pull request Mar 8, 2017

Filesystem changes made for mbed-os-5.4 have broken mbed 2 compilation #3910

Closed

0xc0170 added needs: work and removed needs: review labels Mar 8, 2017

geky force-pushed the fix-size_t-mbed-2 branch from 9f739d1 to c27563a Compare March 8, 2017 21:54

0xc0170 added needs: CI and removed needs: work labels Mar 9, 2017

0xc0170 added the release-version: 5.4.1 label Mar 9, 2017

geky changed the title ~~Fix size_t issue for mbed 2 builds~~ Fix mbed 2 builds Mar 10, 2017

geky added needs: work and removed needs: CI labels Mar 10, 2017

geky added 2 commits March 10, 2017 11:04

Fixed size_t issue for mbed 2 builds

000894d

Filesystem: Restored LocalFileSystem tests for mbed 2

51b58b1

geky force-pushed the fix-size_t-mbed-2 branch from a39e4dc to 51b58b1 Compare March 10, 2017 17:04

geky added ready for merge and removed needs: work labels Mar 10, 2017

sg- merged commit 684fcc1 into ARMmbed:master Mar 10, 2017

sg- removed the ready for merge label Mar 10, 2017

Fix mbed 2 builds #3864

Fix mbed 2 builds #3864

Conversation

geky commented Mar 1, 2017

bridadan left a comment

Choose a reason for hiding this comment

bridadan commented Mar 1, 2017

geky commented Mar 1, 2017

mbed-bot commented Mar 2, 2017

0xc0170 commented Mar 2, 2017

geky commented Mar 2, 2017

0xc0170 commented Mar 8, 2017

adbridge commented Mar 8, 2017 • edited Loading

geky commented Mar 8, 2017

geky commented Mar 8, 2017

mbed-bot commented Mar 8, 2017

bridadan commented Mar 8, 2017

mbed-bot commented Mar 8, 2017

Result: SUCCESS

Output

mbed-bot commented Mar 9, 2017

0xc0170 commented Mar 9, 2017

0xc0170 commented Mar 9, 2017

mbed-bot commented Mar 9, 2017

0xc0170 commented Mar 9, 2017

0xc0170 commented Mar 9, 2017

geky commented Mar 9, 2017

geky commented Mar 9, 2017

mbed-bot commented Mar 9, 2017

Result: SUCCESS

Output

mbed-bot commented Mar 9, 2017

bridadan commented Mar 9, 2017

mbed-bot commented Mar 9, 2017

geky commented Mar 10, 2017

0xc0170 commented Mar 10, 2017

theotherjimmy commented Mar 10, 2017

theotherjimmy commented Mar 10, 2017

geky commented Mar 10, 2017

mbed-bot commented Mar 10, 2017

Result: SUCCESS

Output

mbed-bot commented Mar 10, 2017

bridadan commented Mar 10, 2017

mbed-bot commented Mar 10, 2017

bridadan commented Mar 10, 2017

mbed-bot commented Mar 10, 2017

geky commented Mar 10, 2017

adbridge commented Mar 8, 2017 •

edited

Loading