bd: Add randomness to block device test and more debug friendly output #3747

geky · 2017-02-11T00:01:50Z

Added to block device test during debug of SPIFBlockDevice and I2CEEBlockDevice. Currently this tests is duplicated for all block devices.

Uses rand to select pseudorandom blocks, slightly better coverage and no longer will intensively wear block zero.
Added nice printing of sizes
Added preview of read/write data for debugging
Added an error mask of where errors occured in block for debugging

simonqhughes · 2017-02-13T11:30:14Z

Please could you take a look at the heap_block_device/main.cpp error at:

https://jenkins-internal.mbed.com/job/ARMmbed/job/mbed-os/job/PR-3747/1/consoleFull

[K64F ARM] Build failures:
[K64F ARM]   * K64F::ARM::FEATURES-TESTS-FILESYSTEM-HEAP_BLOCK_DEVICE
[K64F ARM]         Building project heap_block_device (K64F, ARM)
[K64F ARM]         Scan: ARM
[K64F ARM]         Scan: FEATURE_LWIP
[K64F ARM]         Scan: FEATURE_STORAGE
[K64F ARM]         Scan: heap_block_device
[K64F ARM]         Compile [100.0%]: main.cpp
[K64F ARM]         [Error] main.cpp@50,0:  #308: more than one instance of overloaded function "log" matches the argument list:
[K64F ARM]         [Error] main.cpp@50,0:  #308: more than one instance of overloaded function "log" matches the argument list:
[K64F ARM]         
[K64F ARM] [mbed] ERROR: "python" returned error code 1.
[K64F ARM] [mbed] ERROR: Command "python -u /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os/tools/test.py -t ARM -m K64F -c --source /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os --build /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os/BUILD/tests/K64F/ARM --test-spec /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os/BUILD/tests/K64F/ARM/test_spec.json" in "/builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os"
[K64F ARM] ---

@geky

geky · 2017-02-13T15:08:39Z

Ah, multiple float/double overloads for the math functions caused inference problems when passed ints.

Should be updated 👍

simonqhughes

As the KL25Z IAR MBED_STACK_STATS_ENABLED handling has been backed out, we need to check CI for this case builds.

bridadan · 2017-02-16T22:00:37Z

retest uvisor

sg- · 2017-02-17T16:13:16Z

/morph test-nightly

mbed-bot · 2017-02-17T22:16:38Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1630

Test failed!

0xc0170 · 2017-02-20T15:30:35Z

please look at failures. Some seems to be legitimate. I'll rerun it, because some seem to be not relevant to this patch.

This patch might affect integration of this branch to master #3762

/morph test-nightly

bridadan · 2017-02-20T19:04:28Z

/morph test-nightly

mbed-bot · 2017-02-20T19:49:27Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1658

Example Build failed!

0xc0170 · 2017-02-21T11:54:09Z

One example for nucleo and for only IAR, please have a look

0xc0170 · 2017-02-27T13:28:55Z

Any update for this?

geky · 2017-02-27T15:59:08Z

Will update, there's a bit of work to match last minute changes to the block device api

0xc0170 · 2017-03-06T16:28:58Z

Will update, there's a bit of work to match last minute changes to the block device api

Any update?

geky · 2017-03-07T22:52:12Z

Updated and rebased against master, although this will have a merge conflict with #3866 because of stupid C++ rules regarding implicit casts of const member function pointers... : (

geky · 2017-03-07T23:05:09Z

@bridadan, this also removes the ifdefs preventing tests from running on small devices (no longer an issue).

bridadan · 2017-03-07T23:36:52Z

@bridadan, this also removes the ifdefs preventing tests from running on small devices (no longer an issue).

This makes me a very happy 🐼

simonqhughes · 2017-03-08T17:38:49Z

Looks good to me. Lets merge.

geky · 2017-03-08T19:19:06Z

/morph test-nightly

mbed-bot · 2017-03-08T19:48:58Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1657

Build failed!

0xc0170 · 2017-03-09T15:24:25Z

Please look at the failures

geky · 2017-03-09T23:57:37Z

/morph test

mbed-bot · 2017-03-10T00:14:16Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1668

Build failed!

0xc0170 · 2017-03-10T10:01:11Z

18:03:22         [Error] main.cpp@39,1: cannot convert 'bd_size_t (BlockDevice::*)() const {aka long long unsigned int (BlockDevice::*)() const}' to 'bd_size_t (BlockDevice::*)() {aka long long unsigned int (BlockDevice::*)()}' in initialization

All build fails due to error in the test, see above

geky · 2017-03-10T17:39:22Z

I did call it, though I forgot this would happen.

Should be updated

geky · 2017-03-10T20:04:01Z

/morph test-nightly

mbed-bot · 2017-03-10T22:48:26Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1674

All builds and test passed!

bridadan · 2017-03-10T22:59:15Z

Results look good!

0xc0170 · 2017-03-13T13:58:59Z

@simonqhughes Please review

0xc0170 · 2017-03-20T16:11:33Z

@simonqhughes Please review

Any update?

geky requested a review from simonqhughes February 11, 2017 00:01

geky added needs: CI needs: review scope: feature labels Feb 11, 2017

geky force-pushed the bd-verbose-test branch 2 times, most recently from 3327ad1 to 8cdbe31 Compare February 13, 2017 15:08

geky mentioned this pull request Feb 14, 2017

STORAGE: Merging feature-storage branch commits to master #3762

Merged

geky force-pushed the bd-verbose-test branch from 8cdbe31 to ea93262 Compare February 14, 2017 14:58

simonqhughes reviewed Feb 14, 2017

View reviewed changes

0xc0170 added needs: work and removed needs: CI needs: review labels Feb 21, 2017

geky force-pushed the bd-verbose-test branch from ea93262 to 35c5910 Compare March 7, 2017 22:44

geky changed the base branch from feature-storage to master March 7, 2017 22:44

geky added needs: CI and removed needs: work scope: feature labels Mar 8, 2017

geky force-pushed the bd-verbose-test branch from a963ce9 to fc27748 Compare March 9, 2017 23:56

0xc0170 added needs: work and removed needs: CI labels Mar 10, 2017

geky added 2 commits March 10, 2017 11:24

bd: Added randomness to block device test and more debug friendly output

09b3afb

bd: Remove constraints on device for block device tests

704c94d

geky force-pushed the bd-verbose-test branch from fc27748 to 704c94d Compare March 10, 2017 17:38

bridadan added needs: review and removed needs: work labels Mar 10, 2017

sg- added ready for merge release-version: 5.4.2 and removed needs: review labels Mar 22, 2017

sg- merged commit 9677218 into ARMmbed:master Mar 22, 2017

sg- removed the ready for merge label Mar 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bd: Add randomness to block device test and more debug friendly output #3747

bd: Add randomness to block device test and more debug friendly output #3747

geky commented Feb 11, 2017

simonqhughes commented Feb 13, 2017

geky commented Feb 13, 2017 •

edited

Loading

simonqhughes left a comment

bridadan commented Feb 16, 2017

sg- commented Feb 17, 2017

mbed-bot commented Feb 17, 2017

0xc0170 commented Feb 20, 2017

bridadan commented Feb 20, 2017

mbed-bot commented Feb 20, 2017

0xc0170 commented Feb 21, 2017

0xc0170 commented Feb 27, 2017

geky commented Feb 27, 2017

0xc0170 commented Mar 6, 2017

geky commented Mar 7, 2017

geky commented Mar 7, 2017

bridadan commented Mar 7, 2017

simonqhughes commented Mar 8, 2017

geky commented Mar 8, 2017

mbed-bot commented Mar 8, 2017

0xc0170 commented Mar 9, 2017

geky commented Mar 9, 2017

mbed-bot commented Mar 10, 2017

0xc0170 commented Mar 10, 2017

geky commented Mar 10, 2017

geky commented Mar 10, 2017

mbed-bot commented Mar 10, 2017

bridadan commented Mar 10, 2017

0xc0170 commented Mar 13, 2017

0xc0170 commented Mar 20, 2017

bd: Add randomness to block device test and more debug friendly output #3747

bd: Add randomness to block device test and more debug friendly output #3747

Conversation

geky commented Feb 11, 2017

simonqhughes commented Feb 13, 2017

geky commented Feb 13, 2017 • edited Loading

simonqhughes left a comment

Choose a reason for hiding this comment

bridadan commented Feb 16, 2017

sg- commented Feb 17, 2017

mbed-bot commented Feb 17, 2017

Result: FAILURE

Output

0xc0170 commented Feb 20, 2017

bridadan commented Feb 20, 2017

mbed-bot commented Feb 20, 2017

Result: FAILURE

Output

0xc0170 commented Feb 21, 2017

0xc0170 commented Feb 27, 2017

geky commented Feb 27, 2017

0xc0170 commented Mar 6, 2017

geky commented Mar 7, 2017

geky commented Mar 7, 2017

bridadan commented Mar 7, 2017

simonqhughes commented Mar 8, 2017

geky commented Mar 8, 2017

mbed-bot commented Mar 8, 2017

Result: FAILURE

Output

0xc0170 commented Mar 9, 2017

geky commented Mar 9, 2017

mbed-bot commented Mar 10, 2017

Result: FAILURE

Output

0xc0170 commented Mar 10, 2017

geky commented Mar 10, 2017

geky commented Mar 10, 2017

mbed-bot commented Mar 10, 2017

Result: SUCCESS

Output

bridadan commented Mar 10, 2017

0xc0170 commented Mar 13, 2017

0xc0170 commented Mar 20, 2017

geky commented Feb 13, 2017 •

edited

Loading