[toolchains] Refactor sys libs #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph export-build |
|
please be aware that the sys_libs must also be used to generate the start/end group |
|
Oh, thanks! |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
|
Thanks @bridadan, I'm about to add another change. |
theotherjimmy
force-pushed
the
refactor-sys-libs
branch
from
3217c35
to
f1bd0fc
Compare
|
@ilg-ul The new implementation should generate the |
theotherjimmy
force-pushed
the
refactor-sys-libs
branch
from
f1bd0fc
to
3489b14
Compare
bridadan
approved these changes
Jan 17, 2017
|
/morph export-build |
|
/morph test |
|
@theotherjimmy, you're welcome! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 89 All exports and builds passed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Jan 19, 2017
0xc0170
added
ready for merge
release-version: 5.3.4
and removed
needs: review
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor toolchains to use a common sys_libs variable. This allows the exporters to rely on that information.
Status
READY
##Todos