Fixes linking errors when building with debug profile #3577
Conversation
When building with the debug profile, certain ST plaforms error with 'get_i2c_timing' not being defined. This is because the function is not defined as 'static inline', but just 'inline'.
|
/morph test |
|
It looks good. Is there plans to add debug+small builds to CI? Seems like an easy thing we could add to travis even. |
|
I don't have it planned in my immediate future, but it seems like this is a logical thing to add. The only downside is it will basically double the time for builds. This will probably end up being a nightly only thing. |
|
It could just be for a single platform, that would still be quite beneficial. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Let it be nightly ! |
|
@bridadan thanks for fixing this ! |
Ports for Upcoming Targets Fixes and Changes 3488: Dev stm i2c v2 unitary functions ARMmbed/mbed-os#3488 3492: Fix #3463 CAN read() return value ARMmbed/mbed-os#3492 3503: [LPC15xx] Ensure that PWM=1 is resolved correctly ARMmbed/mbed-os#3503 3504: [LPC15xx] CAN implementation improvements ARMmbed/mbed-os#3504 3539: NUCLEO_F412ZG - Add support of TRNG peripheral ARMmbed/mbed-os#3539 3540: STM: SPI: Initialize Rx in spi_master_write ARMmbed/mbed-os#3540 3438: K64F: Add support for SERIAL ASYNCH API ARMmbed/mbed-os#3438 3519: MCUXpresso: Fix ENET driver to enable interrupts after interrupt handler is set ARMmbed/mbed-os#3519 3544: STM32L4 deepsleep improvement ARMmbed/mbed-os#3544 3546: NUCLEO-F412ZG - Add CAN peripheral ARMmbed/mbed-os#3546 3551: Fix I2C driver for RZ/A1H ARMmbed/mbed-os#3551 3558: K64F UART Asynch API: Fix synchronization issue ARMmbed/mbed-os#3558 3563: LPC4088 - Fix vector checksum ARMmbed/mbed-os#3563 3567: Dev stm32 F0 v1.7.0 ARMmbed/mbed-os#3567 3577: Fixes linking errors when building with debug profile ARMmbed/mbed-os#3577
Description
When building with the debug profile, certain ST plaforms error with
'get_i2c_timing' not being defined. This is because the function is not
defined as 'static inline', but just 'inline'.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Related PRs
Should fix the current export-build CI failure on #3534
Todos
Notes to Reviewers
@LMESTM Would you double check this change since you were working on I2C for ST platforms?
@geky Would you please check this since you're a wizard at all things C/C++? 😄