Eclipse debug fixes (build w/ DEBUG=1 and load symbols) #3532
Conversation
janjongboom
changed the title
| @@ -18,7 +18,7 @@ | |||
| <folderInfo id="0.936619452." name="/" resourcePath=""> | |||
| <toolChain id="org.eclipse.cdt.build.core.prefbase.toolchain.957782855" name="No ToolChain" resourceTypeBasedDiscovery="false" superClass="org.eclipse.cdt.build.core.prefbase.toolchain"> | |||
| <targetPlatform id="org.eclipse.cdt.build.core.prefbase.toolchain.957782855.1870418474" name=""/> | |||
| <builder arguments="-j" command="make" id="org.eclipse.cdt.build.core.settings.default.builder.1415080330" incrementalBuildTarget="" keepEnvironmentInBuildfile="false" managedBuildOn="false" name="Gnu Make Builder" superClass="org.eclipse.cdt.build.core.settings.default.builder"/> | |||
| <builder arguments="DEBUG=1 -j" command="make" id="org.eclipse.cdt.build.core.settings.default.builder.1415080330" incrementalBuildTarget="" keepEnvironmentInBuildfile="false" managedBuildOn="false" name="Gnu Make Builder" superClass="org.eclipse.cdt.build.core.settings.default.builder"/> | |||
There was a problem hiding this comment.
No, if you want to enable debugging, you can export with the debug profile. I would accept a change that made the debug profile the default for exporters.
There was a problem hiding this comment.
I did not make it clear what change I was requesting. Please don't pass any special variables to the makefile. We want the make and eclipse default invocation to be exactly the same.
| @@ -35,7 +35,7 @@ | |||
| <stringAttribute key="org.eclipse.cdt.debug.gdbjtag.core.ipAddress" value="localhost"/> | |||
| <stringAttribute key="org.eclipse.cdt.debug.gdbjtag.core.jtagDevice" value="GNU ARM PyOCD"/> | |||
| <booleanAttribute key="org.eclipse.cdt.debug.gdbjtag.core.loadImage" value="{{load_exe}}"/> | |||
| <booleanAttribute key="org.eclipse.cdt.debug.gdbjtag.core.loadSymbols" value="false"/> | |||
| <booleanAttribute key="org.eclipse.cdt.debug.gdbjtag.core.loadSymbols" value="{{load_exe}}"/> | |||
There was a problem hiding this comment.
Yes? But where does this Nevermind, found it.load_exe thing get set in the jinja template?
|
Hey, @janjongboom Would you like me to write the "make the default profile debug" part? I think I know how I would like to do it. |
|
@theotherjimmy Yeah, absolutely! Just want to fix this stuff ;-) |
|
@janjongboom I just had a chat with @sarahmarshy, and she wrote that particular patch yesterday, but did not submit a PR. We will just approve that PR when it comes in (~10 min maybe) |
|
As I understand, this can be closed? |
|
@0xc0170 @theotherjimmy As far as I can see @sarahmarshy's commit does not address the |
|
@janjongboom We should fix the |
janjongboom
force-pushed
the
eclipse-debug
branch
from
7b8d575
to
1a21696
Compare
|
@theotherjimmy Fixed ^ |
|
👍 |
|
@theotherjimmy happy with this patch? |
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 75 All exports and builds passed! |
DEBUG=1flag tomakefor projects exported to Eclipse. Together with Makefile does not supportDEBUG=1anymore... #3530 this enables builds with debug symbols from Eclipse again.@theotherjimmy