Fix deprecated Thread ctor usage in RTOS tests #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulislaw
force-pushed
the
fix_deprecated_thread_ctors
branch
from
e688544
to
a7a723d
Compare
|
/morph test |
|
+1, although heads up this is going to have some pretty nasty conflicts with #3484 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
geky
approved these changes
Dec 21, 2016
|
@bulislaw Please rebase |
Thread spawning constructors are deprecated, start function should be used instead.
bulislaw
force-pushed
the
fix_deprecated_thread_ctors
branch
from
a7a723d
to
ed41ebe
Compare
|
@0xc0170 Done |
|
/morph test |
|
retest uvisor |
bridadan
approved these changes
Dec 27, 2016
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Build warnings are definitely reduced! Nice! |
0xc0170
added
ready for merge
release-version: 5.3.2
and removed
needs: CI
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread spawning constructors are deprecated, start function should be
used instead.
Status
READY