Deduplicate IAR exporter templates and enable a few more targets #3413

theotherjimmy · 2016-12-09T17:36:27Z

Description

Fixes a typo in the IAR definitions dict. should resolve #3412

Status

READY

Todos

export-build CI

Steps to test or reproduce

mbed export -i iar -m nucleo_f746zg from any mbed project would tell you it's not supported, when it could have been.

adustm · 2016-12-09T17:39:24Z

Hi @theotherjimmy
great, thanks ! Can you also upcase "stm32f746ng" "stm32l476vg" and "stm32l476rg" ?

Then I will close the other issue.

theotherjimmy · 2016-12-09T17:40:00Z

Yes. Could you point me at those issues?

theotherjimmy · 2016-12-09T17:42:33Z

@adustm That should do it

theotherjimmy · 2016-12-09T17:48:28Z

/morph export-build

mbed-bot · 2016-12-09T18:25:43Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 48

Exporter Build failed!

theotherjimmy · 2016-12-09T18:32:53Z

looks like the F746ZG does not like being built under IAR's builder.

adustm · 2016-12-12T10:46:54Z

Hello,
Have you detected the build error origin ? (I can't read continuous integration reports...)
It used to build before this change...

theotherjimmy · 2016-12-12T18:14:02Z

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(193) : Error[438]: This instruction is not available in the selected cpu/core

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(222) : Error[438]: This instruction is not available in the selected cpu/core

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(289) : Error[438]: This instruction is not available in the selected cpu/core

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(317) : Error[438]: This instruction is not available in the selected cpu/core

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(193) : Error[50]: Undefined symbol:'S16'

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(193) : Error[50]: Undefined symbol:'S31'

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(92) : Warning[408]: Not recommended operand syntax. Duplicate the first register operand, or select option -j (alternative syntax).

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(110) : Warning[408]: Not recommended operand syntax. Duplicate the first register operand, or select option -j (alternative syntax).

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(114) : Warning[408]: Not recommended operand syntax. Duplicate the first register operand, or select option -j (alternative syntax).

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(131) : Warning[408]: Not recommended operand syntax. Duplicate the first register operand, or select option -j (alternative syntax).

11:58:31 C:\Jenkins\workspace\bm_wrap\1238\examples\mbed-os-example-sockets\mbed-os\rtos\rtx\TARGET_CORTEX_M\TARGET_RTOS_M4_M7\TOOLCHAIN_IAR\HAL_CM4.S(135) : Warning[408]: Not recommended operand syntax. Duplicate the first register operand, or select option -j (alternative syntax).

theotherjimmy · 2016-12-12T18:14:32Z

It looks like the IAR exporter does not get the right CPU.

theotherjimmy · 2016-12-12T18:16:52Z

In particular, it's not getting the FPU. (this is a DISCO_F7467NG build error)

theotherjimmy · 2016-12-12T18:22:15Z

I just checked: the fpu is set to none in the GUI.

bridadan · 2016-12-12T19:37:42Z

@adustm To clarify, it builds fine with IAR when using the mbed build system. But when you export to the IAR IDE and try to build with that, the build fails.

theotherjimmy · 2016-12-12T21:01:25Z

/morph export-build

mbed-bot · 2016-12-12T22:56:15Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 55

Exporter Build failed!

theotherjimmy · 2016-12-13T00:22:57Z

/morph export-build

mbed-bot · 2016-12-13T00:40:59Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 56

Exporter Build failed!

theotherjimmy · 2016-12-13T00:47:53Z

/morph export-build

mbed-bot · 2016-12-13T01:25:34Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 57

Exporter Build failed!

0xc0170 · 2016-12-13T09:08:36Z

LGTM

There's one failure that is connected to the file name duplicate, There's a fix that got just now integrated, rerunning the export build

/morph export-build

mbed-bot · 2016-12-13T11:34:17Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 58

All exports and builds passed!

adustm · 2016-12-13T12:24:35Z

Hello,
I had to do a lot of changes to make the IAR IDE compile, even after the exporter works. As I don't use the same IAR version than you, I cannot report them here.

One thing I noticed is the fact that the *.h files are listed as objects in the project.
It is not usefull and should be removed.
The c and cpp files are finding 'their' header files through the project / option / C C++ Compiler / Preprocessor / Additional include directories

Could you check that ?

Kind regards
Armelle

0xc0170 · 2016-12-13T13:00:20Z

@> As I don't use the same IAR version than you

What version are you using? Templates are 7.70 that is supported version currently.

One thing I noticed is the fact that the *.h files are listed as objects in the project.
It is not usefull and should be removed.
The c and cpp files are finding 'their' header files through the project / option / C C++ Compiler / Preprocessor / Additional include directories

Create a separate issue for this if needed. I'll provide short answer for this, we had similar discussion in another pull request a while ago. I can find it for you that issue. For consistency, headers are part of the project. It is not about being found by a tool, but being part of a workspace so a user can find and edit them (not all tools provide features like listing all headers that are pulled in by a code file for instance). For further discussion, another issue needed as its not related to this patchset. Thanks

theotherjimmy · 2016-12-13T17:28:20Z

We're down to the #3416 error.

/morph export-build

theotherjimmy · 2016-12-13T17:29:09Z

Whoops. old page loaded

mbed-bot · 2016-12-13T18:05:46Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 63

All exports and builds passed!

bridadan

LGTM

theotherjimmy · 2016-12-13T21:47:09Z

@0xc0170 @sg- merge please?

0xc0170 · 2016-12-14T11:49:07Z

@0xc0170 @sg- merge please?

Will be merged soon, most probably today, we are reviewing still some (this was flagged as ready for integration a day ago)

theotherjimmy requested a review from bridadan December 9, 2016 17:37

theotherjimmy mentioned this pull request Dec 9, 2016

export NUCLEO_F746ZG in IAR does not work, probably due to targets.py or targets.json #3412

Closed

Fix typo in IAR definitions

c638d2c

theotherjimmy force-pushed the iar-def-typo branch from 22c3647 to c638d2c Compare December 9, 2016 17:42

theotherjimmy mentioned this pull request Dec 9, 2016

mbed-os-5.3.0-rc2: sockets do not work for NUCLEO_F746ZG in IAR #3387

Closed

bridadan added the needs: work label Dec 12, 2016

Update IAR template and STM M7 part options

2481c46

Remove special case template for F746ZG

80d47e2

Remove special case for RZ-A1H

e29135e

theotherjimmy changed the title ~~Fix typo in IAR definitions~~ Deduplicate IAR exporter templates and enable a few more targets Dec 13, 2016

0xc0170 added the needs: CI label Dec 13, 2016

0xc0170 removed the needs: work label Dec 13, 2016

0xc0170 added ready for merge and removed needs: CI labels Dec 13, 2016

bridadan approved these changes Dec 13, 2016

View reviewed changes

sg- merged commit 6849fd9 into ARMmbed:master Dec 15, 2016

sg- added release-version: 5.3.1 and removed ready for merge labels Dec 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deduplicate IAR exporter templates and enable a few more targets #3413

Deduplicate IAR exporter templates and enable a few more targets #3413

theotherjimmy commented Dec 9, 2016 •

edited

Loading

adustm commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

mbed-bot commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

adustm commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

bridadan commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

theotherjimmy commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

theotherjimmy commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

0xc0170 commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

adustm commented Dec 13, 2016

0xc0170 commented Dec 13, 2016 •

edited

Loading

theotherjimmy commented Dec 13, 2016

theotherjimmy commented Dec 13, 2016 •

edited

Loading

mbed-bot commented Dec 13, 2016

bridadan left a comment

theotherjimmy commented Dec 13, 2016

0xc0170 commented Dec 14, 2016

Deduplicate IAR exporter templates and enable a few more targets #3413

Deduplicate IAR exporter templates and enable a few more targets #3413

Conversation

theotherjimmy commented Dec 9, 2016 • edited Loading

Description

Status

Todos

Steps to test or reproduce

adustm commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

theotherjimmy commented Dec 9, 2016

mbed-bot commented Dec 9, 2016

Result: FAILURE

Output

theotherjimmy commented Dec 9, 2016

adustm commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

bridadan commented Dec 12, 2016

theotherjimmy commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

Result: FAILURE

Output

theotherjimmy commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

Result: ABORTED

Output

theotherjimmy commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

Result: FAILURE

Output

0xc0170 commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

Result: SUCCESS

Output

adustm commented Dec 13, 2016

0xc0170 commented Dec 13, 2016 • edited Loading

theotherjimmy commented Dec 13, 2016

theotherjimmy commented Dec 13, 2016 • edited Loading

mbed-bot commented Dec 13, 2016

Result: SUCCESS

Output

bridadan left a comment

Choose a reason for hiding this comment

theotherjimmy commented Dec 13, 2016

0xc0170 commented Dec 14, 2016

theotherjimmy commented Dec 9, 2016 •

edited

Loading

0xc0170 commented Dec 13, 2016 •

edited

Loading

theotherjimmy commented Dec 13, 2016 •

edited

Loading