Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase stack size in malloc test for Cortex-A #3362

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Increase stack size in malloc test for Cortex-A #3362

merged 1 commit into from
Dec 9, 2016

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Dec 3, 2016

Increase the stack size used in the malloc test to prevent stack overflows on Cortex-A devices.

@c1728p9
Increase stack size in malloc test for Cortex-A
92d11df 
Increase the stack size used in the malloc test to prevent stack
overflows on Cortex-A devices.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Dec 3, 2016

/morph test-nightly

@c1728p9 c1728p9 mentioned this pull request Dec 3, 2016
Closed
@mbed-bot
Copy link

mbed-bot commented Dec 3, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1197

All builds and test passed!

@TomoYamanaka
Copy link
Contributor

There is no problem about this change.

0xc0170
0xc0170 reviewed Dec 5, 2016
View reviewed changes
TESTS/mbedmicro-rtos-mbed/malloc/main.cpp
@@ -7,7 +7,11 @@
#endif

#define NUM_THREADS 5
#if defined(__CORTEX_A9)
#define THREAD_STACK_SIZE DEFAULT_STACK_SIZE
Copy link
Contributor

@0xc0170 0xc0170 Dec 5, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between DEFAULT_STACK_SIZE and 256 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170

Cortex-A in general will require more stack space than Cortex-M.
Therefore it is necessary to divide the definition by "#ifdef" as same as other test. By using its value CI test sequece is carried out.
For example:
TESTS\mbedmicro-rtos-mbed\basic\main.cpp

In Cortex-A, DEFAULT_STACK_SIZE is 2048 byte. Maybe in Cortex-M, it is 256Byte.

Copy link
Contributor

@0xc0170 0xc0170 Dec 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wondered if that macro should not be DEFAULT_STACK_SIZE for any cortex. Russ, what do you think?

@0xc0170 0xc0170 merged commit 0e2d1cb into ARMmbed:master Dec 9, 2016
@TomoYamanaka TomoYamanaka mentioned this pull request Dec 20, 2016
Merged
sg- pushed a commit that referenced this pull request Jan 9, 2017
@TomoYamanaka @sg-
[RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API (#3470)
9af3173 
* [RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API

PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @russ already supported in PR #3362.

Reference for issue of test error is here.
#3273

Reference for PR to update RTX for Cortex-M.
#1702

* Revert "[RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API"

This reverts commit e71f79a.

* [RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API

PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @c1728p9 already supported in PR #3362.

Reference for issue of test error is here.
#3273

Reference for PR to update RTX for Cortex-M.
#1702
adbridge pushed a commit that referenced this pull request Jan 13, 2017
@TomoYamanaka @adbridge
Support RTX v4.80 for Cortex-A and a few Malloc API
4a4ab8b 
PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @russ already supported in PR #3362.

Reference for issue of test error is here.
#3273

Reference for PR to update RTX for Cortex-M.
#1702
adbridge pushed a commit that referenced this pull request Jan 13, 2017
@TomoYamanaka @adbridge
Support RTX v4.80 for Cortex-A and a few Malloc API
aa43fb0 
PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @c1728p9 already supported in PR #3362.

Reference for issue of test error is here.
#3273

Reference for PR to update RTX for Cortex-M.
#1702
simonqhughes pushed a commit to simonqhughes/mbed-os-1 that referenced this pull request Jan 31, 2017
@TomoYamanaka @simonqhughes
[RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API (ARMmbed#…
d6ca2f9 
…3470)

* [RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API

PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @russ already supported in PR ARMmbed#3362.

Reference for issue of test error is here.
ARMmbed#3273

Reference for PR to update RTX for Cortex-M.
ARMmbed#1702

* Revert "[RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API"

This reverts commit e71f79a.

* [RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API

PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @c1728p9 already supported in PR ARMmbed#3362.

Reference for issue of test error is here.
ARMmbed#3273

Reference for PR to update RTX for Cortex-M.
ARMmbed#1702
simonqhughes pushed a commit that referenced this pull request Jan 31, 2017
@TomoYamanaka @simonqhughes
[RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API (#3470)
fed8044 
* [RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API

PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @russ already supported in PR #3362.

Reference for issue of test error is here.
#3273

Reference for PR to update RTX for Cortex-M.
#1702

* Revert "[RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API"

This reverts commit e71f79a.

* [RZ/A1H]Support RTX v4.80 for Cortex-A and a few Malloc API

PR to update RTX to v4.80 for Cortex-A.
In the latest CI test, three tests result in an error. The cause is mainly three points
- Unsupport RTX v4.80 for Cortex-A
- Insufficient stack size of thread defined in test
- A few Lack of Malloc API in GCC
Therefore, I supported to these. For the stack size for test, @c1728p9 already supported in PR #3362.

Reference for issue of test error is here.
#3273

Reference for PR to update RTX for Cortex-M.
#1702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomoYamanaka TomoYamanaka TomoYamanaka left review comments

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c1728p9 @mbed-bot @TomoYamanaka @0xc0170