Baudrate in test spec #3257
Merged
Baudrate in test spec #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the get_config function was checking the equality of a set and a list. However the list's equality depends on order, so this change casts it to set to prevent an infinite loop.
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
theotherjimmy
approved these changes
Nov 10, 2016
|
The way in which you're accessing the config data should be fine. You are creating an extra toolchain, target, and config object which you are throwing away before you do any compiling, but that should be fine. |
|
Not in this way: |
|
Lots of CI issues today, sorry again. Had to restart the system. Restarting now. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1066 All builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the baudrate in the test spec file (used by Greentea for automated testing) based on the mbed config setting for the stdio default baud rate: https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_lib.json#L9
There was another patch that was necessary to prevent an issue when getting the config data. Before, the
get_configfunction inbuild_api.pywas checking the equality of a set and a list. However the list's equality depends on order, so now it is casted it to a set to prevent an infinite loop.Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos
FYI @stevew817