Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MBED_DEPRECATED def order to support Keil 4 #3250

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Change MBED_DEPRECATED def order to support Keil 4 #3250

merged 1 commit into from
Nov 15, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Nov 10, 2016 •
edited by sg-
Loading

Oringinally #3245 by @micromint

Description

MBED_DEPRECATED macro breaks builds using Keil uVision4. The 'deprecated' attribute does not allow arguments using ARMCC 5.03 on Keil 4.74. Changing #ifdef order reinstates support for Keil uVision4. Tested with Keil 4.74, Keil 5.21 and GCC ARM Embedded 5.4 2016q3.

Status

READY

Todos

@sg-
Copy link
Contributor

sg- commented Nov 10, 2016

/morph test

@sg- sg- added the needs: CI label Nov 10, 2016
@sg- sg- mentioned this pull request Nov 10, 2016
Closed
@mbed-bot
Copy link

Result: NOT_BUILT

Your command has finished executing! Here's what you wrote!

/morph test

@geky
Copy link
Contributor

geky commented Nov 10, 2016

Not sure if there is an issue with the bot
/morph test

@bridadan
Copy link
Contributor

Sorry for the NOT_BUILT error, this occurred because I enabled too much parallelization in the build pipeline and jobs were being dropped. Should be fixed now.

@bridadan
Copy link
Contributor

Lots of CI issues today, sorry again. Had to restart the system. Restarting now.

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1063

All builds and test passed!

@micromint
Copy link
Contributor

Are there still issues with the CI builds? Two CI checks for this PR and for #3253 have been pending for 4 days.

@bridadan
Copy link
Contributor

retest uvisor

@bridadan
Copy link
Contributor

Both of the pending CIs are passing, we've just exceeded the GitHub API rate limit :)

@sg-
Copy link
Contributor

sg- commented Nov 15, 2016

@mazimkhan @marhil01 Can API rate limit error be handled more gracefully or fixed?

@sg- sg- merged commit 84f401b into ARMmbed:master Nov 15, 2016
@theotherjimmy theotherjimmy deleted the ARM5.03-deprecation branch November 15, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@c1728p9 c1728p9 c1728p9 approved these changes

@geky geky geky approved these changes

Assignees
No one assigned
Labels
release-version: 5.2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@theotherjimmy @sg- @mbed-bot @geky @bridadan @micromint @c1728p9 @0xc0170