Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callback - Relax type-deduction in callback class #3244

Merged
merged 3 commits into from
Nov 16, 2016
Merged

callback - Relax type-deduction in callback class #3244

merged 3 commits into from
Nov 16, 2016

Commits on Nov 9, 2016

  1. callback - Fixed type-deduction when inheritance is involved 

    The type deduction for the callback constructors was to strict and
prevented implicit casts for the context pointer stored internally.

As noted by @pan-, relaxing the contraints on the templated
parameters allows C++ to correctly infer implicit casts such as
conversions between child and parent classes when inheritance is
involved.

As an additional benefit, this may help the user experience by
defering invalid type errors to when the types are expanded,
limiting the number of error messages presented to users.
    @geky
    geky committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    3ba3bb5 View commit details
    Browse the repository at this point in the history

  2. callback - Adopted relaxed type-deduction for bound functions 

    Adopting relaxed type-deduction in bound functions better aligns with
the same overloads for member functions, and provides an alternative
solution for the void pointer cast issue, which removes a large amount
of cruft.
    @geky
    geky committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    3544228 View commit details
    Browse the repository at this point in the history

  3. callback - Added tests for inheritance and implicit casts

    @geky
    geky committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    9c0c95a View commit details
    Browse the repository at this point in the history