Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Export - Make] Add message that informs the user which hex to flash #3222

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Nov 7, 2016

Description

Resolves #2962 part B in a way that should be noticable

Reviews

Examples

It looks like this (k64f, no hex file merging):

$ make -j 
[SNIP]
Compile: port_api.c
Compile: sleep.c
Compile: i2c_api.c
Compile: rtc_api.c
../mbed-os/targets/TARGET_Freescale/TARGET_KSDK2_MCUS/TARGET_MCU_K64F/drivers/fsl_enet.c: In function 'ENET_SetTxBufferDescriptors':
../mbed-os/targets/TARGET_Freescale/TARGET_KSDK2_MCUS/TARGET_MCU_K64F/drivers/fsl_enet.c:493:29: warning: comparison between pointer and integer
         if (txBuffSizeAlign != NULL)
                             ^
link: mbed-os-example-blinky.elf
'arm-none-eabi-objcopy' -O binary mbed-os-example-blinky.elf mbed-os-example-blinky.bin
'arm-none-eabi-objcopy' -O ihex mbed-os-example-blinky.elf mbed-os-example-blinky.hex
===== bin file ready to flash: .build/mbed-os-example-blinky.bin =====

OR this (nrf52_dk, hex file merging):

$ make -j
[SNIP]
link: mbed-os-example-blinky.elf
'arm-none-eabi-objcopy' -O binary mbed-os-example-blinky.elf mbed-os-example-blinky.bin
'arm-none-eabi-objcopy' -O ihex mbed-os-example-blinky.elf mbed-os-example-blinky.hex
NOTE: the srec_cat binary is required to be present in your PATH. Please see http://srecord.sourceforge.net/ for more information.
srec_cat .././mbed-os/targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/sdk/softdevice/s132/hex/s132_nrf52_2.0.0_softdevice.hex  -intel mbed-os-example-blinky.hex -intel -o mbed-os-example-blinky-combined.hex -intel --line-length=44
===== hex file ready to flash: .build/mbed-os-example-blinky-combined.hex =====

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For targets that don't have a srec step, could you refer the user to the .bin file instead of the .hex file? I only say this because I know .bin is widely supported across all the board interface firmwares (STLink, DAPLink, etc), however I'm not sure about .hex.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Nov 7, 2016

@bridadan Nope. We only merge the hex. I can do it for non-srec step makefiles. ;)

@bridadan
Copy link
Contributor

bridadan commented Nov 7, 2016

@theotherjimmy Oops, that's what I meant. Yes please!

@theotherjimmy
Copy link
Contributor Author

@bridadan Done.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants