Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Export-Make] Use internal class variable for resolving templates in makefiles #3187

Merged
merged 1 commit into from
Nov 3, 2016
Merged

[Export-Make] Use internal class variable for resolving templates in makefiles #3187

merged 1 commit into from
Nov 3, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Nov 2, 2016 •
edited by 0xc0170
Loading

Status

READY

Reviews

Steps to test or reproduce

Before:

$ mbed export -i make_gcc_arm -m <any>
[mbed] Auto-installing missing Python modules...
Scan: .
Scan: FEATURE_LWIP
Scan: FEATURE_COMMON_PAL
Scan: FEATURE_UVISOR
Scan: FEATURE_BLE
Scan: FEATURE_LOWPAN_ROUTER
Scan: FEATURE_NANOSTACK
Scan: FEATURE_THREAD_END_DEVICE
Scan: FEATURE_THREAD_ROUTER
Scan: FEATURE_THREAD_BORDER_ROUTER
Scan: FEATURE_LOWPAN_BORDER_ROUTER
Scan: FEATURE_NANOSTACK_FULL
Scan: FEATURE_LOWPAN_HOST
Scan: FEATURE_STORAGE
Traceback (most recent call last):
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/project.py", line 244, in <module>
    main()
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/project.py", line 240, in main
    zip_proj=zip_proj, build_profile=profile)
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/project.py", line 93, in export
    build_profile=build_profile, silent=silent)
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/project_api.py", line 229, in export_project
    macros=macros)
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/project_api.py", line 90, in generate_project_files
    exporter.generate()
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/export/cdt/__init__.py", line 14, in generate
    super(Eclipse, self).generate()
  File "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/export/makefile/__init__.py", line 103, in generate
    raise NotSupportedException("This make tool is in development")
tools.utils.NotSupportedException: This make tool is in development
[mbed] ERROR: "python" returned error code 1.
[mbed] ERROR: Command "python -u /home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi/mbed-os/tools/project.py -i eclipse_gcc_arm -m K64F --source ." in "/home/jimbri01/src/arm-mbed/oob-mbed-os-example-wifi"

---

After:

$ mbed export -i eclipse_gcc_arm -m k64f
[mbed] Auto-installing missing Python modules...
Scan: .
Scan: FEATURE_LWIP
Scan: FEATURE_COMMON_PAL
Scan: FEATURE_UVISOR
Scan: FEATURE_BLE
Scan: FEATURE_LOWPAN_ROUTER
Scan: FEATURE_NANOSTACK
Scan: FEATURE_THREAD_END_DEVICE
Scan: FEATURE_THREAD_ROUTER
Scan: FEATURE_THREAD_BORDER_ROUTER
Scan: FEATURE_LOWPAN_BORDER_ROUTER
Scan: FEATURE_NANOSTACK_FULL
Scan: FEATURE_LOWPAN_HOST
Scan: FEATURE_STORAGE

@theotherjimmy
Use internal class variable for resolving templates in makefiles
c2470e9 
This allows other exporters to inherit from make and change the name of
the exporter without breaking.
@0xc0170 0xc0170 mentioned this pull request Nov 3, 2016
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 3, 2016

@bridadan @sarahmarshy command export-build supports testing make and it's children like eclipse ? (I could not quickly find relevant info in test_exporters.py script file)

@bridadan
Copy link
Contributor

bridadan commented Nov 3, 2016

@0xc0170 Currently the tools/test/export/build_test.py script only supports IAR and uVision, however PR #3172 adds the capability to build with make, so this should be coming very soon!

@sg- sg- merged commit f044786 into ARMmbed:master Nov 3, 2016
oter pushed a commit to oter/mbed-os that referenced this pull request Nov 21, 2016
Merge tag 'mbed-os-5.2.2' into fix_5.2
537d70d 
Release mbed OS 5.2.2 and mbed lib v129

Known issues in this release

There is currently a DNS resolution failure in Thread mode with this release. This causes a failure in the
mbed-os-example-client. This will be fixed in a subsequent release. This can be worked around by reverting
to mbed-os-5.2.0

Ports for Upcoming Targets

3011: Add u-blox Sara-N target. ARMmbed#3011
3099: MAX32625 ARMmbed#3099
3151: Add support for FRDM-K82F ARMmbed#3151
3177: New mcu k22512 fixing pr 3136 ARMmbed#3177

Fixes and Changes

2990: [tools] Parallel building of tests ARMmbed#2990
3008: NUCLEO_F072RB: Fix wrong timer channel number on pwm PB_5 pin ARMmbed#3008
3013: STM32xx - Change how the ADC internal pins are checked before pinmap_ ARMmbed#3013
3023: digital_loop tests update for STM32 ARMmbed#3023
3041: [nRF5] - added implementation of API of serial port flow control configuration. ARMmbed#3041
3092: [tools + tests] Adding parallelized build option for iar and uvision exporters ARMmbed#3092
3084: [nrf5] fix in Digital I/O : a gpioe pin was uninitialized badly ARMmbed#3084
3009: TRNG enabled. TRNG APIs implemented. REV A/B/C/D flags removed. Warnings removed ARMmbed#3009
3139: Handle [NOT_SUPPORTED] exception in make.py ARMmbed#3139
3074: Target stm init gcc alignement ARMmbed#3074
3140: [tests] Replacing getchar with RawSerial getc in greentea-client ARMmbed#3140
3158: Added support for 6lowpan PAN ID filter to mbed mesh api configuration ARMmbed#3158
2988: Update of can_api.c fixing ARMmbed#2987 ARMmbed#2988
3175: Updating IAR definition for the NCS36510 for IAR EW v7.8 ARMmbed#3175
3170: [tests] Preventing test from printing before Greentea __sync ARMmbed#3170
3169: [Update of ARMmbed#3014] Usb updates ARMmbed#3169
3143: CFStore fix needed for the Cloud Client ARMmbed#3143
3135: lwip - Fix memory leak in k64f cyclic-buffer overflow ARMmbed#3135
3048: Make update.py test compile examples prior to updating mbed-os version. ARMmbed#3048
3162: lwip/nsapi - Clean up warnings in network code ARMmbed#3162
3161: nsapi - Add better heuristic for the default record of DNS queries ARMmbed#3161
3173: [Exporters] Add a device_name to microbit entry in targets.json ARMmbed#3173
3072: i2c_loop tests update for STM32 ARMmbed#3072
2958: Allowing mbed_app.json files to be discovered for tests. ARMmbed#2958
2969: [nRF52] - switch irq priorities of driver handlers to the lowest level ARMmbed#2969
3078: lwip: Allow several configuration macros to be set externally (bis) ARMmbed#3078
3165: Add address type checks to NanostackInterface ARMmbed#3165
3166: nsapi_dns: Provide 2 IPv6-hosted default servers ARMmbed#3166
3171: [tools] Fixing project.py -S printing problem ARMmbed#3171
3172: [Exporters] New export-build tests ARMmbed#3172
3184: ARMmbed#3183 Compiler warning in trng_api.c with K64F  ARMmbed#3184
3185: Update tests to fix build failures. Also make the code similar to oth ARMmbed#3185
3104: [NuMaker] Support CAN and fix PWM CLK error ARMmbed#3104
3182: Exporter documentation ARMmbed#3182
3186: MultiTech mDot - add back SPI3 pins ARMmbed#3186
3187: [Export-Make] Use internal class variable for resolving templates in makefiles ARMmbed#3187
3195: [Exporters - Make-based] Quote the shell call in mkdir and rmdir ARMmbed#3195
3204: [Export build-test] Directory traversal error ARMmbed#3204
3189: [Exporters - Make-based] Force make exporter to search PATH for compilers ARMmbed#3189
3200: Using Popen for uVision and unifying the structure of the build function ARMmbed#3200
3075: nsapi - Add standardized return types for size and errors ARMmbed#3075
3221: u-blox odin w2 drivers update ARMmbed#3221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahmarshy sarahmarshy sarahmarshy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theotherjimmy @0xc0170 @bridadan @sarahmarshy @sg-