Add .hpp to list of Uvision Exporter extensions

[nuket]

Doing an export fails if .hpp files are included, this patch add it to the list of recognized extensions.

Log

mbed export -i UVISION5 -m NRF52_DK
Traceback (most recent call last):
  File "c:\mbed-project\mbed-os\tools\project.py", line 234, in <module>
    main()
  File "c:\mbed-project\mbed-os\tools\project.py", line 230, in main
    zip_proj=zip_proj, build_profile=profile)
  File "c:\mbed-project\mbed-os\tools\project.py", line 93, in export
    build_profile=build_profile, silent=silent)
  File "c:\mbed-project\mbed-os\tools\project_api.py", line 229, in export_project
    macros=macros)
  File "c:\mbed-project\mbed-os\tools\project_api.py", line 90, in generate_project_files
    exporter.generate()
  File "c:\mbed-project\mbed-os\tools\export\uvision\__init__.py", line 189, in generate
    'project_files': self.format_src(srcs),
  File "c:\mbed-project\mbed-os\tools\export\uvision\__init__.py", line 175, in format_src
    grouped[group] = [self.uv_file(src) for src in files]
  File "c:\mbed-project\mbed-os\tools\export\uvision\__init__.py", line 141, in uv_file
    type = self.file_types[ext.lower()]
KeyError: '.hpp'
[mbed] ERROR: "python" returned error code 1.
[mbed] ERROR: Command "python -u c:\mbed-project\mbed-os\tools\project.py -i uvision5 -m NRF52_DK --source ." in "c:\mbed-project"

[theotherjimmy]

I do have a question: is there line you modified now longer than 80?

[nuket]

Nope, it's 59 characters long.

[0xc0170]

+1

[sg-]

@nuket What about IAR or other IDEs?

[nuket]

Unfortunately, I don't have a copy of IAR.

On October 13, 2016 18:17:36 Sam Grove [email protected] wrote:

@nuket What about IAR or other IDEs?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#3010 (comment)

[sg-]

OK - lets wait until someone can verify and add support there too. Point solutions make the maintenance of exporters really painful.

[theotherjimmy]

I don't see this as a point solution: it modifies a dict that is a mapping that is only used in this one exporter type.

[0xc0170]

I had a look at this PR, tested locally ,reviewed all tools we support. This should be good to go.

Reasons:

• .hpp is supported in our build API, thus tools should also be able to display it
• all tools with this patch support .hpp - only uvision is special that requires this patch, the rest should work out of the box

LGTM

[0xc0170]

/morph export-build

[mbed-bot]

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph export-build

[0xc0170]

/morph export-build

[mbed-bot]

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph export-build

[bridadan]

There's definitely an issue with uVision hanging during the exporter tests, I had to kill it again. I'll try it one more time but in the meantime I'll look into a patch.

/morph export-build

[mbed-bot]

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph export-build

[0xc0170]

@bridadan any update? I dont see how this small change can break exporters, as I tested locally, we accept .hpp in the tools anyway.

[bridadan]

@0xc0170 sorry for the delay in my response. The failure I mentioned has been present (but spurious) in the exporter tests for sometime now. A patch was merged recently that should help with the stability if it was in fact a problem with our tools and not an issue with uVision. I'll go ahead and restart the CI.

/morph export-build

[mbed-bot]

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph export-build

[bridadan]

There was a git issue with one of the machines so I unfortunately had to stop this build so mbed-os testing could become unblocked. Restarting now!

/morph export-build

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

[theotherjimmy]

Yea! that took way too long.