Refactor Target and Config away from global variables #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
force-pushed
the
non-global-config
branch
from
2afe8e3
to
d4f9820
Compare
screamerbg
approved these changes
Sep 21, 2016
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 908 All builds and test passed! |
|
I should note that the bot doesn't do anything fancy with config. In fact, it uses exclusively the default config. Have you tested this locally with some of the existing examples that make use of config (ex https://github.com/ARMmbed/mbed-os-example-client)? |
|
@bridadan the Travis runs config tests. |
|
@theotherjimmy good point, forgot about that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids a multi-threading bug in the online export system