Change default uvision exporter to uvision5 #2614

MarceloSalazar · 2016-09-03T08:51:11Z

uVision4 is no longer maintained by the Keil team (support was stopped
long time ago).

This is why we need to make the uvision exporter able to generate uVision5
projects by default (which is based on software packs).

Also, adding note that the uvision4 exporter is now deprecated and will be
removed in the future.

@0xc0170 @sg-

sg- · 2016-09-09T21:00:07Z

@MarceloSalazar needs a rebase

@sarahmarshy review?

uVision4 is no longer maintained by the Keil team (support was stopped long time ago). This is why we need to make the uvision exporter able to generate uVision5 projects by default (which is based on software packs). Also, adding note that the uvision4 exporter is now deprecated and will be removed in the future.

theotherjimmy · 2016-09-12T19:27:11Z

LGTM 👍

sarahmarshy · 2016-09-12T19:33:09Z

LGTM

theotherjimmy · 2016-09-15T20:54:49Z

tools/test/export/build_test.py

-        if tool == 'uvision' or tool == 'uvision5':
-            log = path.join(project_dir, "build", "build_log.txt")
+        if tool == 'uvision' or tool == 'uvision4':
+            log = path.join(project_dir,"build","build_log.txt")


Could you keep the spaces that were there before?

my bad, should be fixed now

sg- · 2016-09-16T21:45:06Z

/morph export-build

mbed-bot · 2016-09-16T21:56:53Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

sg- · 2016-09-17T17:29:08Z

Seems like there was a change to the entry point for export that needs to be reflected in the tests and possibly documentation.

16:54:57 + python tools/test/export/build_test.py -i uvision5
16:55:08 usage: build_test.py [-h] [-i IDES] [-p PROGRAMS] [-n PROGRAMS]
16:55:08                      [-m MCU [MCU ...]] [-c]
16:55:08 build_test.py: error: argument -i: uvision5 is not a supported toolchain. Supported toolchains are:
16:55:08 iar,      uvision,  uvision4  
16:55:08 Build step 'Execute shell' marked build as failure
16:55:08 Finished: FAILURE
...
16:56:34 + python tools/test/export/build_test.py -i iar
16:56:51 
16:56:51 + deactivate

sarahmarshy · 2016-09-18T00:07:41Z

@sg @MarceloSalazar - That is actually just an entry point for the export build tests, as it limits the options for that switch to the three listed.

This is the line responsible.

MarceloSalazar · 2016-09-20T09:16:25Z

Guys, I'm not entirely sure how this is expected to be fixed. Would you be able to help here?

bridadan · 2016-09-20T11:45:19Z

@sarahmarshy Would you mind helping @MarceloSalazar on what changes need to be made to build_test.py? If you need me to change a command in CI just let me know.

theotherjimmy · 2016-09-20T13:46:02Z

@bridadan: the arguments to the build_test.py need to change in the CI to uvision from uvision5.

bridadan · 2016-09-20T13:53:59Z

Thanks @theotherjimmy, done.

/morph export-build

sarahmarshy · 2016-09-20T14:11:11Z

@bridadan @theotherjimmy No, that will still fail. I'll need to also change that line in the script. Marcelo, the line that I linked to above should become ['iar','uvision5'].

sarahmarshy · 2016-09-20T14:11:49Z

Let me test locally. Just a moment.

theotherjimmy · 2016-09-20T14:15:14Z

The line in that script was changed in this PR to include uvision5

mbed-bot · 2016-09-20T14:21:04Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

sarahmarshy · 2016-09-20T14:22:05Z

@theotherjimmy cool, am an idiot. Good work Marcelo. LGTM

theotherjimmy · 2016-09-20T14:26:09Z

@bridadan Why the do not merge label?

bridadan · 2016-09-20T14:26:20Z

Hang on, the pass was a false success because I was changing the CI config. Need to rerun.

/morph test

mbed-bot · 2016-09-20T15:24:22Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

bridadan · 2016-09-20T15:24:59Z

Just realized I used the wrong test command 😠

/morph export-build

mbed-bot · 2016-09-20T16:09:06Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

bridadan · 2016-09-20T16:15:27Z

IAR has existing failures, uvision is all passing

theotherjimmy · 2016-09-20T16:16:13Z

Those IAR failures are clearly not related to this patch, and I don't think they are regressions.

bridadan · 2016-09-20T18:59:14Z

@theotherjimmy I agree! LGTM. @sarahmarshy ?

sg- added the needs: review label Sep 9, 2016

Marcelo Salazar added 2 commits September 12, 2016 19:46

Minor fix to match with master

1192744

theotherjimmy approved these changes Sep 15, 2016

View reviewed changes

theotherjimmy suggested changes Sep 15, 2016

View reviewed changes

Minor tweak on spaces

64d3381

theotherjimmy approved these changes Sep 16, 2016

View reviewed changes

sg- added needs: CI and removed needs: review labels Sep 16, 2016

sg- added needs: work and removed needs: CI labels Sep 17, 2016

theotherjimmy approved these changes Sep 20, 2016

View reviewed changes

bridadan added the do not merge label Sep 20, 2016

bridadan removed the do not merge label Sep 20, 2016

sg- added ready for merge and removed needs: work labels Sep 20, 2016

sg- merged commit 6fce892 into ARMmbed:master Sep 22, 2016

sg- added release-version: 5.1.5 and removed ready for merge labels Sep 22, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default uvision exporter to uvision5 #2614

Change default uvision exporter to uvision5 #2614

MarceloSalazar commented Sep 3, 2016

sg- commented Sep 9, 2016

theotherjimmy commented Sep 12, 2016

sarahmarshy commented Sep 12, 2016

theotherjimmy Sep 15, 2016

MarceloSalazar Sep 16, 2016

sg- commented Sep 16, 2016

mbed-bot commented Sep 16, 2016

sg- commented Sep 17, 2016

sarahmarshy commented Sep 18, 2016 •

edited

Loading

MarceloSalazar commented Sep 20, 2016

bridadan commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

bridadan commented Sep 20, 2016

sarahmarshy commented Sep 20, 2016

sarahmarshy commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

mbed-bot commented Sep 20, 2016

sarahmarshy commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

bridadan commented Sep 20, 2016

mbed-bot commented Sep 20, 2016

bridadan commented Sep 20, 2016

mbed-bot commented Sep 20, 2016

bridadan commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

bridadan commented Sep 20, 2016

Change default uvision exporter to uvision5 #2614

Change default uvision exporter to uvision5 #2614

Conversation

MarceloSalazar commented Sep 3, 2016

sg- commented Sep 9, 2016

theotherjimmy commented Sep 12, 2016

sarahmarshy commented Sep 12, 2016

theotherjimmy Sep 15, 2016

Choose a reason for hiding this comment

MarceloSalazar Sep 16, 2016

Choose a reason for hiding this comment

sg- commented Sep 16, 2016

mbed-bot commented Sep 16, 2016

Result: FAILURE

sg- commented Sep 17, 2016

sarahmarshy commented Sep 18, 2016 • edited Loading

MarceloSalazar commented Sep 20, 2016

bridadan commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

bridadan commented Sep 20, 2016

sarahmarshy commented Sep 20, 2016

sarahmarshy commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

mbed-bot commented Sep 20, 2016

Result: SUCCESS

sarahmarshy commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

bridadan commented Sep 20, 2016

mbed-bot commented Sep 20, 2016

Result: ABORTED

bridadan commented Sep 20, 2016

mbed-bot commented Sep 20, 2016

Result: FAILURE

bridadan commented Sep 20, 2016

theotherjimmy commented Sep 20, 2016

bridadan commented Sep 20, 2016

sarahmarshy commented Sep 18, 2016 •

edited

Loading