[TY51822r3] fixed to use Serial without flow control

[ytsuboi]

Original TARGET_NRF5 HAL only support Serial with flow control, but CTS and RTS on TY51822r3 was not connected to mbed interface chip. So this patch enables to support serial without flow control on nRF5.

[0xc0170]

cc @pan-

[0xc0170]

/morph test

[0xc0170]

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=NRF51_DK,TY51822R3

[mbed-bot]

[Build 816]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 666

Test failed!

[0xc0170]

/morph test

[0xc0170]

build 816 is good. Morpheus test failed, I suspect something with CI, I restarted it

[pan-]

@ytsuboi Instead of define excluding code it would be more better to use the configuration system:

• One parameter which control the hardware flow control which can be NRF_UART_HWFC_DISABLED or NRF_UART_HWFC_DISABLED.
• One parameter for the RTS pin which might be equal to NRF_UART_PSEL_DISCONNECTED
• One parameter for the CTS pin which might also be equal to NRF_UART_PSEL_DISCONNECTED

@anangl What do you think ?

[0xc0170]

@ytsuboi Instead of define excluding code it would be more better to use the configuration system:

cc @bogdanm

[bogdanm]

It seems like it'd be indeed better to use the configuration system, although this looks like the kind of configuration that belongs in the targets, not in a library. Which is perfectly fine, since the config system does work with configuration data in targets: https://github.com/ARMmbed/mbed-os/blob/master/docs/config_system.md

[ytsuboi]

@pan- @0xc0170 @bogdanm Got, it. I will talk about this detail with @toyowata .

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 667

Test failed!

[ytsuboi]

@pan- @0xc0170 I succeed to use config system with #if directive like this way 0417427 , but failed with if statement. How can I use configured value from the code? Could you please explain that on this page or provide a sample code?

[nvlsianpu]

A C if statement must works as well - didn't you omit definition (re-definition) of e.g. WITH_FC in *.cpp (I saw #undef in *.h)

[nvlsianpu]

@ytsuboi Ihave made another PR #2535. Could you close this PR?

[ytsuboi]

Got it. Thanks @nvlsianpu

[ytsuboi]

#2535 will not solve this issue. Reopened.

[nvlsianpu]

In which case it didn't work? I tested it as std output for printf() and it works for me in booth cases.
You could look what was selected (as config system result) in mbed_config.h under MBED_CONF_NORDIC_UART_HWFC.

[ytsuboi]

It will not affect on TY51822r3. I need to make another PR for our platform after your PR got merged.

[nvlsianpu]

"overrides": { "uart_hwfc": 0 }
Yes sure.

[nvlsianpu]

@ytsuboi - my changes were merged - you can make a PR with overrides.

[ytsuboi]

Another PR #2555 made.