Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware CRC support to STM32G4 #15392

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

augustozanellato
Copy link
Contributor

Summary of changes

Added support for hardware CRC calculation on STM32G4 based targets

Impact of changes

Migration actions required

Documentation

I think no documentation update is needed.


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Not sure where/how tests should be added.


Reviewers


Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target platform_name test suite result elapsed_time (sec) copy_method
NUCLEO_G474RE-ARMC6 NUCLEO_G474RE drivers-tests-tests-mbed_drivers-crc OK 12.75 default
NUCLEO_G474RE-ARMC6 NUCLEO_G474RE hal-tests-tests-mbed_hal-crc OK 12.74 default
NUCLEO_G431RB-ARMC6 NUCLEO_G431RB drivers-tests-tests-mbed_drivers-crc OK 14.99 default
NUCLEO_G431RB-ARMC6 NUCLEO_G431RB hal-tests-tests-mbed_hal-crc OK 16.39 default

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 20, 2023

CI started

@mergify mergify bot added the needs: CI label Mar 20, 2023
@mbed-ci
Copy link

mbed-ci commented Mar 20, 2023

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 20, 2023
@augustozanellato
Copy link
Contributor Author

@jeromecoutant thanks for the review. I’m mentioning you directly because I saw you work for ST.
I have a nucleo-g491re that advertises itself to the host computer as Mbed compatible (MSD contains a MBED.htm that redirects to https://os.mbed.com/platforms/ST-NUCLEO-G491RE/) but there isn’t an official target.
I got it to work by more or less copying stuff from the nucleo-g474re target. Would a PR here be reviewed/eventually accepted for that?

@jeromecoutant
Copy link
Collaborator

@0xc0170 failed tests are strange, maybe you could restart ?

@jeromecoutant
Copy link
Collaborator

@augustozanellato I will be pleased to review a PR to introduce NUCLEO-G491RE !

As ex, you can have a look on #15343 or #15199

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2023

CI restarted

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Apr 3, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2023

There was anothe breakage in CI earier this week, I restarted CI again.

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants