Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CAN DLC length value #15373

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Check CAN DLC length value #15373

merged 1 commit into from
Jan 16, 2023

Conversation

Martyx00
Copy link
Contributor

Summary of changes

Change on how the incoming CAN message DLC field is processed by the STM HAL. Previously, any value up to 0xF was allowed. The updated code limits this to value maximum of 8. Values higher than 8 are only used in CANFD which is not affected by this code change.

Impact of changes

CAN message DLC value can no longer be higher than 8 in standard CAN mode.

Migration actions required

None

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@jeromecoutant
Copy link
Collaborator

Hi
Maybe could you reference here tickets with issue and discussion for this topic ?
Thx

@Martyx00
Copy link
Contributor Author

#15361

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 added ready for merge release-type: patch Indentifies a PR as containing just a patch and removed needs: CI labels Jan 16, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2023

@jeromecoutant as you already approved previous PR, I'll merge this now.

I am creating generic fix PR now

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2023

@jeromecoutant can you verify this is required also for Mbed OS 5.15 ? If yes, can you send PR fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants