Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuvoton: I2C: Fix potential role switch failure #15333

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Nuvoton: I2C: Fix potential role switch failure #15333

merged 1 commit into from
Sep 26, 2022

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Sep 23, 2022

Summary of changes

This PR tries to fix potential failure in I2C master/slave role switch.

Fix targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NUMAKER_IOT_M252
  • NUMAKER_IOT_M263A
  • NU_M2354

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
Nuvoton: I2C: Fix potential role switch failure
dbc0f5b 
Fix in i2c_do_trsn(), interrupt doesn't change back to enabled due to premature return.

Fix targets:
-   NUMAKER_PFM_NANO130
-   NUMAKER_PFM_NUC472
-   NUMAKER_PFM_M453
-   NUMAKER_PFM_M487/NUMAKER_IOT_M487
-   NUMAKER_IOT_M252
-   NUMAKER_IOT_M263A
-   NU_M2354
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 23, 2022
@ciarmcom ciarmcom requested a review from a team September 23, 2022 08:30
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Sep 26, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 7bb01c1 into ARMmbed:master Sep 26, 2022
@mergify mergify bot removed the ready for merge label Sep 26, 2022
@ccli8 ccli8 deleted the nuvoton_fix_i2c_role_switch branch September 27, 2022 01:18
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: nuvoton release-version: 6.17.0 release-version: 6.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @saheerb @mbedmain