Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename: PwmOut::read_pulsewitdth_us() to PwmOut::read_pulsewidth_us() #15302

Merged
merged 4 commits into from
Jun 27, 2022
Merged

rename: PwmOut::read_pulsewitdth_us() to PwmOut::read_pulsewidth_us() #15302

merged 4 commits into from
Jun 27, 2022

Conversation

yutotnh
Copy link
Contributor

@yutotnh yutotnh commented Jun 21, 2022

Summary of changes

Renamed PwmOut::read_pulsewitdth_us() to PwmOut::read_pulsewidth_us()

Impact of changes

Users who use PwmOut::read_pulsewitdth_us() will have to rename it to PwmOut::read_pulsewidth_us()

Migration actions required

Documentation

None

Pull request type 

[*] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[*] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team June 21, 2022 15:30
@ciarmcom
Copy link
Member

@yutotnh, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the typo. This should be fixed.

However, not breaking the code, can we kept the old function, adding MBED_DEPRECATED to it and let users know they should use the fixed version.

Keep this change as it is, just add the old name and call the new fixed function/method.

@mergify mergify bot dismissed 0xc0170’s stale review June 23, 2022 13:01

Pull request has been modified.

@yutotnh
Copy link
Contributor Author

yutotnh commented Jun 23, 2022

Thanks for noticing the typo. This should be fixed.

However, not breaking the code, can we kept the old function, adding MBED_DEPRECATED to it and let users know they should use the fixed version.

Keep this change as it is, just add the old name and call the new fixed function/method.

Thank you for explaining specifically. I fixed it.

@mergify mergify bot added needs: CI and removed needs: work labels Jun 23, 2022
@mbed-ci
Copy link

mbed-ci commented Jun 23, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

0xc0170
0xc0170 previously requested changes Jun 24, 2022
View reviewed changes
drivers/include/drivers/PwmOut.h Outdated Show resolved Hide resolved
@mergify mergify bot added the needs: work label Jun 24, 2022
@mergify mergify bot dismissed 0xc0170’s stale review June 24, 2022 23:23

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2022

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot removed the needs: CI label Jun 27, 2022
@0xc0170 0xc0170 merged commit 6fcd9c6 into ARMmbed:master Jun 27, 2022
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Jun 27, 2022
@mergify
Copy link

mergify bot commented Jun 27, 2022

This PR does not contain release version label after merging.

@yutotnh yutotnh deleted the rename-read_pulsewitdth_us branch June 27, 2022 15:07
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Jun 28, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2022

This PR does not contain release version label after merging.

Fixed

@multiplemonomials multiplemonomials mentioned this pull request Jul 9, 2022
Merged
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: core component: hal release-version: 6.17.0 release-version: 6.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yutotnh @ciarmcom @mbed-ci @0xc0170 @saheerb @mbedmain