Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcp_out: fix tcp_output_fill_options() arguments #15274

Merged
merged 1 commit into from
Apr 26, 2022
Merged

tcp_out: fix tcp_output_fill_options() arguments #15274

merged 1 commit into from
Apr 26, 2022

Conversation

hifoolno
Copy link
Contributor

Summary of changes

Fix tcp_output_fill_options() arguments as done in LwIP:
lwip-tcpip/lwip@f36e51e

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 20, 2022
@ciarmcom
Copy link
Member

@hifoolno, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 20, 2022 14:30
@mergify mergify bot added needs: CI and removed needs: review labels Apr 21, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 25, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit d17beb7 into ARMmbed:master Apr 26, 2022
@mergify mergify bot removed the ready for merge label Apr 26, 2022
huanghu578 added a commit to huanghu578/mbed-os that referenced this pull request Jun 12, 2022
@huanghu578
Revert "Merge pull request ARMmbed#15274 from hifoolno/bug4"
96ba1de 
This reverts commit d17beb7, reversing
changes made to 2d652c9.
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: connectivity release-version: 6.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hifoolno @ciarmcom @0xc0170 @mbed-ci @mbedmain