-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update psutil to 5.6.7 and PyElfTools to 0.27 #15151
Conversation
@maxgerhardt, thank you for your changes. |
Fixes "ImportError: cannot import name 'MutableMapping' from 'collections'" for Python 3.10
Is this backward compatible? We currently test with older version of python (3.6 or so, I can find out if it would make a difference but I believe anything 3.x should work). |
Per Github diff for psutil between 5.6.6 and 5.6.7 only the code compile error was fixed (giampaolo/psutil@release-5.6.6...release-5.6.7) and this should thus not affect any other Python version. For PyElfTools they fixed the mentioned error in a way to be compatible with all newer Python3 versions while still having back-compatibility with the old one, as one can see in the original offending import is now refactored into py3compat.py which does try:
from collections.abc import MutableMapping # python >= 3.3
except ImportError:
from collections import MutableMapping # python < 3.3 and is thus compatible with all Python versions. In total from pyelftools 0.25 to 0.27 a lot has been updated (see eliben/pyelftools@v0.25...v0.27) but given that they CI test with |
We will run internal tests and if all good we can run CI here tomorrow |
Ci started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Update psutil version in requirements.txt from 5.6.6 to 5.6.7.
If I install the requirements on Windows 10 with Python 3.10.0 (
python -m pip install -r mbed-os\requirements.txt
) I am greeted withThe compile error is fixed in the next minor version of
psutil
in accordance to odoo/odoo#62919 (comment), more precisely giampaolo/psutil@e15fbda.Also updates PyElfTools to 0.27 to get it working on Python 3.10.0. Otherwise
Is encountered.
MutableMapping
fromcollections
was moved tocollections.abc
in newer Python versions (refer to e.g. pypa/setuptools#1401).Impact of changes
Fixes installation of dependencies on Windows.
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers