Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterruptIn: add note about enabling interrupts in rise/fall #15149

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Oct 21, 2021

Summary of changes

Fixes #8188
Make it obvious, only calling rise/fall methods, IRQ are active. Nothing more needed.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Fixes ARMmbed#8188
Make it obvious, only calling rise/fall methods, IRQ are active. Nothing more needed.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 21, 2021
@ciarmcom ciarmcom requested a review from a team October 21, 2021 14:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 22, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 22, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit d9b2b7d into ARMmbed:master Oct 25, 2021
@mergify mergify bot removed the ready for merge label Oct 25, 2021
@0xc0170 0xc0170 deleted the fix-issue-8188 branch October 26, 2021 12:02
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRF52 interrupts already activated by fall/rise call
5 participants