Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2354: Enable post-build for custom board partially with Mbed CLI #15140

Merged
merged 1 commit into from
Oct 13, 2021
Merged

M2354: Enable post-build for custom board partially with Mbed CLI #15140

merged 1 commit into from
Oct 13, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Oct 13, 2021

Summary of changes

With Mbed CLI, this PR tries to enable post-build for custom board to some degree (not completely).
The build process still sees NuMaker-M2354's partition/ and applies its mcuboot build options. Custom board must align on these.

With Mbed CLI2, custom board can be fully supported

Impact of changes 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
M2354: Fix stdin abnormal on NuMaker-IoT-M2354 with Mbed CLI
173e407 
Due to post-build script not supporting custom board, both the below UART configurations are enabled on NuMaker-IoT-M2354 board:
-   UART0 PA7/PA6 enabled by bl2.bin
-   UART0 PB9/PB8 enabled by tfm_s.bin and later by mbed
Both PA7/PA6 and PB9/PB8 enabled on UART0, PB8 gets disturbed and stdin mis-behaves on NuMaker-IoT-M2354 board.

NuMaker-M2354       : UART TX/RX = UART0 PA7/PA6
NuMaker-IoT_M2354   : UART TX/RX = UART0 PB9/PB8

This bugfix tries to enable post-build for custom board to some degree (not completely), with Mbed CLI.
NOTE: For Mbed CLI, the build process still sees NuMaker-M2354's partition/ and applies its mcuboot build options. Custom board must align on these.
0xc0170
0xc0170 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the frozen tools check was already accepted for the previous fix in the same file

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 added ready for merge release-type: patch Indentifies a PR as containing just a patch labels Oct 13, 2021
@0xc0170 0xc0170 merged commit ea0538e into ARMmbed:master Oct 13, 2021
@mergify mergify bot removed the ready for merge label Oct 13, 2021
@ccli8 ccli8 deleted the nuvoton_m2354_tfm_cli1-post-build_custom_board branch October 14, 2021 01:07
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.15.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @0xc0170 @mbed-ci @mbedmain