Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled interrupts on smt32f7 and stm32h7 before calling disable data cache #15006

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Disabled interrupts on smt32f7 and stm32h7 before calling disable data cache #15006

merged 1 commit into from
Aug 17, 2021

Conversation

mikaleppanen
Copy link

Summary of changes

Impact of changes

Interrupts are disabled before calling disable data cache on Ethernet initialization.

Fixes #14999

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Disabled interrupts on smt32f7 and stm32h7 before calling disable dat…
096ce41 
…a cache

Interrupts are disabled before calling disable data cache on Ethernet initialization.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 16, 2021
@ciarmcom ciarmcom requested a review from a team August 16, 2021 11:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team August 16, 2021 13:02
LMESTM
LMESTM approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LMESTM
Copy link
Contributor

LMESTM commented Aug 16, 2021

@mikaleppanen thanks for the Pull Request. I didn't know it was spread over so many files when I asked you to send it

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 16, 2021

Ci started

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 16, 2021

Tests will fail due to Gcc issue in CI, we will restart later today

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 16, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Aug 16, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 17, 2021

Restarting test, looks like a network hiccup

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit cf37de4 into ARMmbed:master Aug 17, 2021
@mergify mergify bot removed the ready for merge label Aug 17, 2021
@mikaleppanen mikaleppanen deleted the irq_disable_eth_init branch August 18, 2021 07:17
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMESTM LMESTM LMESTM approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: connectivity devices: st release-version: 6.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard fault on DISCO F769NI that occurs when STM Ethernet driver is initialized
6 participants
@mikaleppanen @ciarmcom @LMESTM @0xc0170 @mbed-ci @mbedmain