-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements.txt - remove manifest-tool 1.5.2 and mbed-cloud-sdk #14979
Conversation
@moshe-shahar, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove manifest-tool - Apache-2.0 from License.md file
@moshe-shahar, thank you for your changes. |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@0xc0170 , thank you for the quick response. |
@moshe-shahar @0xc0170 note that https://github.com/ARMmbed/mbed-os/blob/master/tools/device_management.py depends on these legacy components. We probably should deprecate/remove the device management features also then from Mbed CLI1. |
Thanks Teemu, I'll create a separate issue to deprecate this. |
I created #15009 |
Summary of changes
Remove
manifest-tool
andmbed-cloud-sdk
from mbed-os's requirements as those are PDMC's requirement and not mbed-os.manifest tool
v1.5.2 is very old version and not the recommended release for PDMC.Newer
manifest tool
(>=2.0.0) releases don't requiresmbed-cloud-sdk
.Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers