Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt - remove manifest-tool 1.5.2 and mbed-cloud-sdk #14979

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

moshe-shahar
Copy link
Contributor

@moshe-shahar moshe-shahar commented Aug 5, 2021

Summary of changes

Remove manifest-tool and mbed-cloud-sdk from mbed-os's requirements as those are PDMC's requirement and not mbed-os.
manifest tool v1.5.2 is very old version and not the recommended release for PDMC.
Newer manifest tool (>=2.0.0) releases don't requires mbed-cloud-sdk.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 5, 2021
@ciarmcom ciarmcom requested a review from a team August 5, 2021 09:30
@ciarmcom
Copy link
Member

ciarmcom commented Aug 5, 2021

@moshe-shahar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove manifest-tool - Apache-2.0 from License.md file

@ciarmcom
Copy link
Member

ciarmcom commented Aug 5, 2021

@moshe-shahar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 5, 2021 11:00
@moshe-shahar moshe-shahar changed the title requirements.txt - remove manifest-tool 1.5.2 requirements.txt - remove manifest-tool 1.5.2 and mbed-cloud-sdk Aug 5, 2021
@moshe-shahar
Copy link
Contributor Author

Also remove manifest-tool - Apache-2.0 from License.md file
@0xc0170 ,
Done.
I also removed mbed-cloud-sdk. See the PR description.

@moshe-shahar moshe-shahar requested review from 0xc0170 and removed request for a team August 5, 2021 11:19
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 5, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Aug 5, 2021
@mbed-ci
Copy link

mbed-ci commented Aug 5, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 3244f97 into ARMmbed:master Aug 5, 2021
@mergify mergify bot removed the ready for merge label Aug 5, 2021
@moshe-shahar moshe-shahar deleted the patch-1 branch August 5, 2021 13:43
@moshe-shahar
Copy link
Contributor Author

@0xc0170 , thank you for the quick response.

@teetak01
Copy link
Contributor

@moshe-shahar @0xc0170 note that https://github.com/ARMmbed/mbed-os/blob/master/tools/device_management.py depends on these legacy components.

We probably should deprecate/remove the device management features also then from Mbed CLI1.

@teetak01
Copy link
Contributor

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 17, 2021

Thanks Teemu, I'll create a separate issue to deprecate this.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 17, 2021

I created #15009

@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants