Fix RawSerial when used with ARMCC microlib #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function vsnprintf does not properly handle a size of zero for the destination buffer, and will write data to it. If the buffer is set to null this will cause a hardfault. This patch adds a workaround for this bug by using a buffer of size 1.
|
Not your patch but reviewing it caught something else. Something about the implementation using a buffer on the stack with a magic size or dynamically allocating makes me shiver. Any ideas on a better way to handle this?? |
|
@bogdanm you added support for printf in RawSerial right? Do you have any thoughts on this? If this code is only going to be used by a single thread then a static buffer could be used. |
|
On second glance and the dynamic allocation isn't being checked for success. IMO exporting the buffer size to the user or user supplied buffer may be the way to go but sure there are better solutions than that! |
|
Is the buffer something that should be addressed in a separate PR? If it is I can open an issue for it. |
|
Lets get this fix in now and then address the buffer in a separate issue. |
|
Created #1498 to track this |
0xc0170
added a commit
that referenced
this pull request
Jan 11, 2016
Fix RawSerial when used with ARMCC microlib
deepakvenugopal
added a commit
to deepakvenugopal/mbed-os
that referenced
this pull request
Feb 9, 2018
…changes from c9bf20f..43c7ec2 43c7ec2 Merge branch 'release_internal' into release_external ed76459 Merge pull request ARMmbed#1558 from ARMmbed/IOTTHD-2195 8d3bcb7 Add new function to unit tests 56f66a4 Review correction 8b7d018 Move indirect queue size public API to net_interface d877c9e Review corrections c25e476 Remove Eclipse project files for external release d51f442 Merge branch 'release_internal' into release_external 135c48d Increase Thread SED buffer size for big packets 70931a7 Fix indirect queue packet ordering 10e51a4 API for changing Thread SED parent buffer size 6122d24 dereference null value issue fixed. (ARMmbed#1557) d1378dc Clear IPv6 neighbor cache in partition change (ARMmbed#1554) 7610e91 Child neighbor entry updates (ARMmbed#1550) c727295 cleared neighbours with child address that are not ours (ARMmbed#1549) 80b4d72 Thread partition merge mode TLV change (ARMmbed#1546) edd7599 RLOC was updated before clearing child info (ARMmbed#1547) a666056 router short address set to 0xfffe for non routers (ARMmbed#1543) 759ab05 delete route set and link set entries for a router ID (ARMmbed#1540) 23a1265 REED advertisement handling (Thread spec 5.16.3): (ARMmbed#1535) 0a32cb4 added active and pending timestamps to child update response (ARMmbed#1533) d0eec80 Fix error case memory leak (ARMmbed#1537) da9860f Pending set after link sync (ARMmbed#1526) ffa1569 Thread router network data update after link sync (ARMmbed#1530) 3b46d8d Fix defects found by coverity (ARMmbed#1529) 3a57101 Fix compiler warnings and update traces (ARMmbed#1523) c288227 Add extension check for partition weight drop in parent selection (ARMmbed#1521) d8dea28 network data cleared after router forms new partition (ARMmbed#1525) 44a85e5 removed router flagging for thread_management_server file (ARMmbed#1524) 1cbced9 Merge pull request ARMmbed#1520 from ARMmbed/IOTTHD-2105_2 3d07365 Review corrections to network data clearing 22a0375 Clear network data from lost children ffd8517 added a new thread management function (ARMmbed#1519) 80af9cb Thread BR network data clearing (ARMmbed#1518) 5a6f6b5 thread nvm valgrind uninitialized data fix (ARMmbed#1517) d5e2198 Add API for partition weighting set (ARMmbed#1513) 8811d6f multicast forwarding scope changed and address registration updated. (ARMmbed#1516) c277384 printf to tr_info (ARMmbed#1515) bb21264 Thread combined nvm test (ARMmbed#1507) 76f7725 Primary BBR fixes from interop (ARMmbed#1512) 12ed5ab FHSS unit test: fixed fhss mac interface test (cherry picked from commit 805eb42e4416b00cc018dc32dceb353d0b6c8bb6) dd21ea9 Remvoed unnecessary trace print's. cb6e78b FHSS unit test: fixed fhss beacon tasklet test (cherry picked from commit abe6d671b058f4f069741eab24d51e4d62d550b0) 237b3d4 Fhss info print (ARMmbed#1486) 0f39a47 FHSS: Do not update synch monitor right after superframe change (cherry picked from commit 99d50ad9d7f8dad80f10c2a4303f4e75ab31a3c2) c9a098f Fixed Timeoout force which actually never generate timeout. 957c7fb Pana server and client update: ae230e5 FHSS: Update Beacon synch info in critical state 84bd8a4 FHSS: Synchronization must be done in critical state fb1b163 Pan coordinator blacklist update 39fe6ba Added missing HAVE_RPL compiler flag 16a1bc5 MLE bootsrap and message timeout update eeb2d39 enable BBR to support multicast registration in non commercial networks (ARMmbed#1509) 4ea2bf8 uri modified. (ARMmbed#1510) f443853 timeout corrected for neighbour entry (ARMmbed#1508) ea93c1f Thread dev conf taken use (ARMmbed#1503) 5d5b239 bug fix in bbr start (ARMmbed#1505) 8dbd521 commented a trace. (ARMmbed#1504) 145dbdf device conf copy fix (ARMmbed#1502) f60268f eid&random mac moved to device conf struct (ARMmbed#1497) df18635 Let MAC choose address when mesh forwarding 42f916b fixed BBR stop to remove network data and routing information (ARMmbed#1500) e058c2a pbbr changes (ARMmbed#1499) 1ece307 Merge pull request ARMmbed#1485 from ARMmbed/merge_release_back dda8164 thread address handling updated. (ARMmbed#1496) 1dc21a1 thread extension fixes. (ARMmbed#1495) 543fe98 Merge branch 'release_internal' bade70e Dua req changes (ARMmbed#1494) 1979df8 added status to MLR response and implemeted BMLR.ntf multicast. (ARMmbed#1492) 1807c01 mle class initialisation (ARMmbed#1488) d809831 Merge pull request ARMmbed#1479 from ARMmbed/merge_release_to_master bce812d Update license to Thread test file (ARMmbed#1483) aaa4b1f Revert eclipse file removal git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack git-subtree-split: 43c7ec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function vsnprintf does not properly handle a size of zero for
the destination buffer, and will write data to it. If the buffer is
set to null this will cause a hardfault. This patch adds a workaround
for this bug by using a buffer of size 1.