Deprecate the Greentea metrics API #14914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicole-osaz, thank you for your changes. |
Patater
previously approved these changes
Jul 13, 2021
0xc0170
previously approved these changes
Jul 13, 2021
|
@nicole-osaz The CI is failing (the results will come in a bit). From the current logs, I was able to retrieve the error |
|
Looks we are missing a headerfile include: #include "platform/mbed_toolchain.h" |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mergify
bot
dismissed stale reviews from Patater and 0xc0170
Pull request has been modified.
Patater
force-pushed
the
my_mbed-os_branch
branch
from
1ad932d
to
4679613
Compare
|
Rebased to apply the fixup commit |
Patater
previously approved these changes
Jul 16, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Patater
previously approved these changes
Jul 16, 2021
0xc0170
previously approved these changes
Jul 16, 2021
|
@nicole-osaz Can you add license header via a new pull request? I realized this file does not have any |
mergify
bot
dismissed stale reviews from Patater and 0xc0170
Pull request has been modified.
|
Please rebase instead of merging (remove 2a6b7c2 merge commit) |
Patater
force-pushed
the
my_mbed-os_branch
branch
from
b652f02
to
29baf0a
Compare
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
LDong-Arm
reviewed
Jul 16, 2021
| @@ -7,11 +26,13 @@ | |||
| /** | |||
| * Setup platform specific metrics | |||
| */ | |||
| MBED_DEPRECATED_SINCE("mbed-os-6.13", "Greentea metrics API are deprecated") | |||
There was a problem hiding this comment.
We released mbed-os-6.13 today, so the starting version will be mbed-os-6.14
0xc0170
previously requested changes
Jul 20, 2021
| @@ -7,11 +26,13 @@ | |||
| /** | |||
| * Setup platform specific metrics | |||
| */ | |||
| MBED_DEPRECATED_SINCE("mbed-os-6.13", "Greentea metrics API are deprecated") | |||
Add the deprecated macro to where the Greentea metrics API is declared. Fixes ARMmbed#14790
Add missing license header to greentea_metrics.h
Patater
force-pushed
the
my_mbed-os_branch
branch
from
df9dfb6
to
2445169
Compare
|
Rebased to apply fixup commit |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jul 22, 2021
Patater
approved these changes
Jul 23, 2021
mergify
bot
added
release version missing
|
This PR does not contain release version label after merging. |
0xc0170
added
release-type: patch
|
Fixed |
mbedmain
added
release-version: 6.14.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the deprecated macro to where the Greentea metrics API is declared.
Fixes #14790
Summary of changes
The Greentea metrics API is no longer supported, so a deprecated macro has been added to where it is declared.
Impact of changes
Migration actions required
The Greentea metrics APIs are now deprecated. Any users of the Greentea metrics API should discontinue their use.
Documentation
We should also update the mbed-os-5-docs repo to remove any mention of Greentea metrics
Pull request type
Test results
Reviewers