FatFs: upgrade to R0.14b

[ndrs-pst]

Summary of changes

Current upstream version of FatFs was now R0.14b with a lot of fixed since R0.13a. LINK
So we migrated Mbed-OS modification in R0.13a back to R0.14b and change some that affect in FATFileSystem.cpp

Impact of changes

FatFs version upgrade that may introduce new regression from upstream.

Migration actions required

FatFs has been upgraded to R0.14b. This comes with the following API changes requiring migration for direct users of FatFs. Users of the Mbed OS C++ class FATFileSystem do not need to change their use of FATFileSystem.

f_mkfs() now takes a MKFS_PARAM *opt instead of a BYTE opt and DWORD au.
f_fdisk() now takes an LBA_t ptbl[] instead of a DWORD *szt.

Documentation

None

---

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

@rajkan01 @michalpasztamobica

---

[ciarmcom]

@ndrs-pst, thank you for your changes.
@rajkan01 @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

[ciarmcom]

@ndrs-pst, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

[ciarmcom]

This pull request has automatically been marked as stale because it has had no recent activity. @rajkan01, @ARMmbed/mbed-os-maintainers, @ARMmbed/mbed-os-core, please complete review of the changes to move the PR forward. Thank you for your contributions.

[0xc0170]

AStyle job failed with just one line, please fix.

[ndrs-pst]

@0xc0170 Fixed AStyle job already 🚀

[0xc0170]

We had earlier update that was later closed from @ladislas

@rajkan01 @michalpasztamobica

Please review

[0xc0170]

Ci started

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

[0xc0170]

Back to review. I would like @ARMmbed/mbed-os-core to approve

[Patater]

Are there any "Migration actions required" for users of FatFs APIs as a result of this upgrade? Maybe we can point to FatFs's release notes about any API changes.

I see the release notes say:
Changed some API functions, f_mkfs() and f_fdisk(). but, that's not really enough to tell users what to change, just that they need to change.

Any other migrations/changes needed?

[ndrs-pst]

As far as I checked, the significant of API change was f_mkfs() that the author allow more parameters to pass to.
So, the migration that preserve same behavior would be in FATFileSystem.cpp FATFileSystem::format() which specified zero value to opt.n_fat, opt.align, opt.n_root and let FatFs to determine default value inside.

Left R0.13c vs Right R0.14b

f_expand() : Just typo fixed.
f_fdisk() : Just changing the argument notation to be array of LBA_t instead of pointer to DWORD.

Regards.

[Patater]

I've added a migration section to the PR description, which will end up in the next Mbed OS release notes.