Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-wisun] Add system time read/write callbacks to mbed-mesh-api #14754

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Jun 9, 2021

Summary of changes

Add system time read/write callbacks to mbed-mesh-api. Nanostack will use the callbacks for system time synchronisation in the mesh network.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter , @mikaleppanen , @juhhei01 @JarkkoPaso


@ciarmcom
Copy link
Member

ciarmcom commented Jun 9, 2021

@artokin, thank you for your changes.
@mikter @mikaleppanen @ARMmbed/mbed-os-maintainers please review.

Arto Kinnunen and others added 2 commits June 9, 2021 13:30
- Add new API for setting system time read and write callbacks.
- Update ws_pae to use the new time service.
Allow Nanostack to read and write system time to synchronise time in
the mesh network. By default feature is enabled in the mesh json-
configuration.
@artokin artokin requested review from juhhei01, JarkkoPaso, mikaleppanen and mikter and removed request for mikter June 9, 2021 11:10
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 17, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jun 18, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 18, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2021

CI started

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jun 18, 2021
@mbed-ci
Copy link

mbed-ci commented Jun 18, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2021

CI restaretd

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels Jun 21, 2021
@artokin
Copy link
Contributor Author

artokin commented Jun 23, 2021

@0xc0170 , would you please run the CI again as #14806 is merged now?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 23, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 23, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 3
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants