-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase SPI stack size to 2048 for BlueNrg driver #14750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Jun 8, 2021
@tymoteuszblochmobica, thank you for your changes. |
@ARMmbed/team-st-ble |
pan-
previously requested changes
Jun 9, 2021
connectivity/drivers/ble/FEATURE_BLE/COMPONENT_BlueNRG_2/BlueNrg2HCIDriver.cpp
Show resolved
Hide resolved
tymoteuszblochmobica
force-pushed
the
size_spi
branch
from
June 9, 2021 13:05
5291a25
to
762fd86
Compare
This is needed to avoid stack overflow due numerous calls and allocation.
tymoteuszblochmobica
force-pushed
the
size_spi
branch
from
June 9, 2021 13:14
762fd86
to
39e821d
Compare
pan-
approved these changes
Jun 10, 2021
0xc0170
approved these changes
Jun 10, 2021
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
I'll reopen in 3 minutes to trigger a new Travis run |
mergify
bot
removed
component: connectivity
needs: CI
release-type: patch
Indentifies a PR as containing just a patch
labels
Jun 11, 2021
0xc0170
added
needs: CI
release-type: patch
Indentifies a PR as containing just a patch
component: connectivity
labels
Jun 11, 2021
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
In case of BlueNrg use there is need to increase SPI stack size to avoid system crash due to insufficient available memory.
Impact of changes
This change has no impact
Migration actions required
Not needed
Documentation
None
Pull request type
Test results
Reviewers
@pan-
@ATmobica