-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed sleep and disabled semihosting on LPC11U35 #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created 3 separate device.h headers for the three LPC11UXX targets, and disabled the features that the LPC11U35 board doesn't have like Semihosting and LocalFileSystem. I also made the call to mbed_interface_disconnect() require DEVICE_SEMIHOSTING, which prevents calls to sleep() from hanging the system on an LPC11U35.
|
||
#define DEVICE_PWMOUT 1 | ||
|
||
#define DEVICE_SEMIHOST 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semihosting is not available on the EA LPC11U35 QuickStart board, as there is no interface chip. Enabling this prevents sleep() from working properly.
bogdanm
added a commit
that referenced
this pull request
Jan 27, 2014
Fixed sleep and disabled semihosting on LPC11U35
bridadan
pushed a commit
that referenced
this pull request
Jun 21, 2016
Updated Unity lib file in mbed-os to pick up the latest Unity library
lrusinowicz
pushed a commit
to lrusinowicz/mbed-os
that referenced
this pull request
Feb 5, 2019
Revert RAM/ROM reporting segment, went in after 5.10.4
lrusinowicz
pushed a commit
to lrusinowicz/mbed-os
that referenced
this pull request
Feb 5, 2019
Revert "Merge pull request ARMmbed#147 from kegilbert/revert-romram-report"
TeroJaasko
added a commit
to TeroJaasko/mbed-os
that referenced
this pull request
Jun 26, 2019
ARMC5 failed to compile the code with debug-profile as va_list is not getting properly defined by <cstdarg>. Convert to stdarg.h which works as expected. While here, remove one extra copy of #include "PlatformMutex.h". Error being fixed: --8<--8<--8<-- Compile [ 81.8%]: ATHandler.cpp [Error] ATHandler.h@552,0: ARMmbed#20: identifier "va_list" is undefined [Error] ATHandler.cpp@1226,0: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") [ERROR] "./mbed-os/features/cellular/framework/AT/ATHandler.h", line 552: Error: ARMmbed#20: identifier "va_list" is undefined "./mbed-os/features/cellular/framework/AT/ATHandler.cpp", line 1226: Error: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") ./mbed-os/features/cellular/framework/AT/ATHandler.cpp: 0 warnings, 2 errors
TeroJaasko
added a commit
to TeroJaasko/mbed-os
that referenced
this pull request
Jun 26, 2019
ARMC5 failed to compile the code with debug-profile (!!) as va_list is getting into std:: namespace when one includes <cstdarg>. Other compilers seem to be more relaxed, and so is ARMC5 if compiled with other profiles. Add the explicit std:: to references of va_list. While here, remove one extra copy of "#include "PlatformMutex.h"" and a "#include <stdarg.h>" which is kind of duplicate of "#include <cstdarg>". Error being fixed: --8<--8<--8<-- Compile [ 81.8%]: ATHandler.cpp [Error] ATHandler.h@552,0: ARMmbed#20: identifier "va_list" is undefined [Error] ATHandler.cpp@1226,0: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") [ERROR] "./mbed-os/features/cellular/framework/AT/ATHandler.h", line 552: Error: ARMmbed#20: identifier "va_list" is undefined "./mbed-os/features/cellular/framework/AT/ATHandler.cpp", line 1226: Error: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") ./mbed-os/features/cellular/framework/AT/ATHandler.cpp: 0 warnings, 2 errors
Jookia
pushed a commit
to Jookia/mbed-os
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created 3 separate device.h headers for the three LPC11UXX targets, and disabled the features that the LPC11U35 board doesn't have like Semihosting and LocalFileSystem. I also made the call to mbed_interface_disconnect() require DEVICE_SEMIHOSTING, which prevents calls to sleep() from hanging the system on an LPC11U35. Ideally, Semihosting and LocalFilesystem should also be disabled on the other non-mbed LPC11UXX boards, but since they use the same target I was unable to determine how to accomplish this.