Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mbed-os-5.15] Corrected nanostack coverity warnings #14147

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[mbed-os-5.15] Corrected nanostack coverity warnings #14147

merged 1 commit into from
Mar 22, 2021

Conversation

mikaleppanen
Copy link

Summary of changes

Corrected nanostack coverity warnings.

This is mbed-os-5.15 version of:
#14146

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin

@ciarmcom ciarmcom requested review from artokin, mikter and a team January 13, 2021 11:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@mikter @artokin @ARMmbed/mbed-os-maintainers please review.

@mikaleppanen mikaleppanen changed the title Corrected nanostack coverity warnings [mbed-os-5.15] Corrected nanostack coverity warnings Jan 13, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2021

Once travis fix lands to 5.15, this will need a rebase (we will let you know).

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2021

Please rebase (travis should be fixed on 5.15 branch now).

@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 22, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 2, 2021

Shall we close this PR or will be rebased?

andypowers
andypowers previously approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mergify mergify bot dismissed andypowers’s stale review February 2, 2021 13:34

Pull request has been modified.

@mikaleppanen
Copy link
Author

Rebased

@ciarmcom ciarmcom added the stale Stale Pull Request label Feb 4, 2021
@adbridge
Copy link
Contributor

adbridge commented Mar 1, 2021

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 1, 2021
@mbed-ci
Copy link

mbed-ci commented Mar 1, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@ciarmcom ciarmcom removed the stale Stale Pull Request label Mar 1, 2021
@adbridge
Copy link
Contributor

CI restarted

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 17, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2021

Test run: FAILED

Summary: 2 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts
  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 22, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 22, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 4
Build artifacts

@LDong-Arm LDong-Arm mentioned this pull request Mar 22, 2021
Merged
@0xc0170 0xc0170 merged commit f9501e7 into ARMmbed:mbed-os-5.15 Mar 22, 2021
@mergify mergify bot removed the ready for merge label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artokin artokin artokin approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers left review comments

@mikter mikter Awaiting requested review from mikter

Assignees
No one assigned
Labels
release-version: 5.15.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikaleppanen @ciarmcom @0xc0170 @adbridge @mbed-ci @artokin @andypowers