Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: set attrs to 19.1.0, fixes python 3.5 issue #14108

Merged
merged 1 commit into from
Jan 4, 2021
Merged

travis: set attrs to 19.1.0, fixes python 3.5 issue #14108

merged 1 commit into from
Jan 4, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 4, 2021 •
edited
Loading

Summary of changes

pytest fetched newer attrs that caused an issue for python 3.5. We found few references with an error and they suggested to use 1.19 version.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 0xc0170 changed the title travis: remove Python 3.5 travis: remove python 3.5 Jan 4, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 4, 2021
@ciarmcom ciarmcom requested a review from a team January 4, 2021 09:30
@ciarmcom
Copy link
Member

ciarmcom commented Jan 4, 2021

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

Travis passed .

0xc0170
0xc0170 commented Jan 4, 2021
View reviewed changes
.travis.yml Outdated
name: "tools-py35"
env: NAME=tools-py3.5
python: 3.5

- <<: *pytools-vm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove 3.6. I'll send one more commit to do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in cd981e3

@0xc0170 0xc0170 changed the title travis: remove python 3.5 travis: remove python 3.5 and 3.6 Jan 4, 2021
rajkan01
rajkan01 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

CI started

This needs to get in asap to unblock dozen of PRs

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

I'll check how this affects the release, will update.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

I am testing the deps, lets try to fix it rather. rebase ongoing until its green

@0xc0170 0xc0170 changed the title travis: remove python 3.5 and 3.6 travis: fix attrs to 19.1.0 Jan 4, 2021
@0xc0170
travis: fix 3.5 test bug in attrs
334e62e 
Using specific version (pre 20) should fix the issue ARMmbed#14110
@0xc0170 0xc0170 mentioned this pull request Jan 4, 2021
Closed
@0xc0170 0xc0170 changed the title travis: fix attrs to 19.1.0 travis: set attrs to 19.1.0, fixes python 3.5 issue Jan 4, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

It is green again. I rebased and cleaned up the history. Ready for review again

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

@ARMmbed/mbed-os-maintainers it's easy fix and unblocks all Prs , lets get this in as soon as possible.

@ladislas
Copy link
Contributor

ladislas commented Jan 4, 2021

But what about not maintaining python versions that have been deprecated for a long time?

@mergify mergify bot added needs: CI and removed needs: review labels Jan 4, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

But what about not maintaining python versions that have been deprecated for a long time?

That was my initial thought, we will review and if removed, will be a new PR.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2021

CI started

@0xc0170 0xc0170 merged commit c28f0d6 into ARMmbed:master Jan 4, 2021
@0xc0170 0xc0170 deleted the travis_remove_py3.5 branch January 4, 2021 16:53
@mergify mergify bot removed the ready for merge label Jan 4, 2021
This was referenced Jan 4, 2021
Merged
Merged
This was referenced Jan 18, 2021
Merged
Merged
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkan01 rajkan01 rajkan01 approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @ciarmcom @ladislas @adbridge @rajkan01 @mbedmain