-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE: Fix periodic advertrising sync based on advertiser list #13988
Merged
0xc0170
merged 1 commit into
ARMmbed:master
from
paul-szczepanek-arm:periodic-sync-ll-fix
Dec 10, 2020
Merged
BLE: Fix periodic advertrising sync based on advertiser list #13988
0xc0170
merged 1 commit into
ARMmbed:master
from
paul-szczepanek-arm:periodic-sync-ll-fix
Dec 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-szczepanek-arm
changed the title
the adv bit is actually optional in aux_adv_ind so is not required fo…
BLE: Fix periodic advertrising sync based on advertiser list
Dec 1, 2020
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Dec 1, 2020
@paul-szczepanek-arm, thank you for your changes. |
0xc0170
approved these changes
Dec 1, 2020
pan-
approved these changes
Dec 1, 2020
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r periodic sync
Summary of changes
Periodic advertising does not sync when relying on the advertiser list. The problem is described here in detail:
#11574
The problem lays in the link layer where processing of the AUX_ADV_IND checks the wrong bit in the bitmask for periodic advertising based on the advertiser list. The addr bit is in fact optional in AUX_ADV_IND (BLUETOOTH CORE SPECIFICATION Version 5.2 | Vol 6, Part B page 2877).
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers
@pan-